Skip to content

TypeScriptify index_patterns/index_patterns/flatten_hit.js#45269

Merged
gospodarsky merged 7 commits intoelastic:masterfrom
gospodarsky:typescriptify-flatten-hit
Sep 16, 2019
Merged

TypeScriptify index_patterns/index_patterns/flatten_hit.js#45269
gospodarsky merged 7 commits intoelastic:masterfrom
gospodarsky:typescriptify-flatten-hit

Conversation

@gospodarsky
Copy link
Copy Markdown

@gospodarsky gospodarsky commented Sep 10, 2019 •
edited
Loading

Summary

A part of the #43441 story

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@gospodarsky gospodarsky self-assigned this Sep 10, 2019
lizozom
lizozom approved these changes Sep 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ppisljar
ppisljar approved these changes Sep 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 11, 2019

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 11, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 12, 2019

💚 Build Succeeded

@gospodarsky gospodarsky added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Sep 12, 2019
@ppisljar
Copy link
Copy Markdown
Contributor

ppisljar commented Sep 12, 2019

retest

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 12, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 13, 2019

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 16, 2019

💚 Build Succeeded

@gospodarsky gospodarsky merged commit 73ef1cb into elastic:master Sep 16, 2019
@gospodarsky gospodarsky mentioned this pull request Sep 16, 2019
Merged
gospodarsky pushed a commit that referenced this pull request Sep 16, 2019
TypeScriptify index_patterns/index_patterns/flatten_hit.js (#45269) (#…
ec4de99 
…45763)

* Typescriptify flatten_hit.js

* Fix path
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 16, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into refactor_cons…
84feac0 
…ole_app_data_flow

* 'master' of github.com:elastic/kibana:
  [Console] Fix leaky mappings subscription (elastic#45646)
  TypeScriptify index_patterns/index_patterns/flatten_hit.js (elastic#45269)

# Conflicts:
#	src/legacy/core_plugins/console/np_ready/public/application/containers/main/main.tsx
#	src/legacy/core_plugins/console/public/quarantined/src/app.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ppisljar ppisljar ppisljar approved these changes

@streamich streamich Awaiting requested review from streamich

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

+1 more reviewer

@lizozom lizozom lizozom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gospodarsky gospodarsky

Labels

Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gospodarsky @elasticmachine @ppisljar @lizozom