Skip to content

Convert tests in index_patterns/index_patterns/__tests__ to Jest#44873

Merged
gospodarsky merged 3 commits intoelastic:masterfrom
alexwizp:43441-toJest
Sep 9, 2019
Merged

Convert tests in index_patterns/index_patterns/__tests__ to Jest#44873
gospodarsky merged 3 commits intoelastic:masterfrom
alexwizp:43441-toJest

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp commented Sep 5, 2019

Partially fix: #43441

Summary

  • Convert tests in index_patterns/index_patterns/tests to Jest

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp alexwizp added Feature:Data Views Data Views code and UI - index patterns before 8.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 Feature:NP Migration labels Sep 5, 2019
@alexwizp alexwizp self-assigned this Sep 5, 2019
@streamich streamich mentioned this pull request Sep 5, 2019
Closed
3 tasks
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 5, 2019

💚 Build Succeeded

@alexwizp alexwizp requested a review from gospodarsky September 6, 2019 09:52
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 6, 2019

💚 Build Succeeded

lizozom
lizozom approved these changes Sep 8, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 9, 2019

💔 Build Failed

@maryia-lapata
Copy link
Copy Markdown
Contributor

maryia-lapata commented Sep 9, 2019

retest

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 9, 2019

💚 Build Succeeded

@gospodarsky gospodarsky merged commit 76a62e2 into elastic:master Sep 9, 2019
@gospodarsky gospodarsky mentioned this pull request Sep 9, 2019
Merged
gospodarsky pushed a commit that referenced this pull request Sep 10, 2019
Convert tests in index_patterns/index_patterns/__tests__ to Jest (#44873
9200b32 
) (#45134)
@alexwizp alexwizp deleted the 43441-toJest branch January 4, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

@ppisljar ppisljar Awaiting requested review from ppisljar

@gospodarsky gospodarsky Awaiting requested review from gospodarsky

1 more reviewer

@lizozom lizozom lizozom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexwizp alexwizp

Labels

Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert remaining data.indexPatterns items to use TS & Jest

5 participants

@alexwizp @elasticmachine @maryia-lapata @lizozom @gospodarsky