Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch |
6ac5821 to
6212d27
Compare
spalger
reviewed
Sep 5, 2019
Contributor
spalger
left a comment
There was a problem hiding this comment.
Please re-request review from @elastic/kibana-operations when ready
6212d27 to
f9414d2
Compare
Contributor
💚 Build Succeeded |
f9414d2 to
8dbaad0
Compare
Contributor
💚 Build Succeeded |
8dbaad0 to
1901fe0
Compare
Contributor
💔 Build Failed |
Author
|
ping @ppisljar :) |
Contributor
💔 Build Failed |
7afc4ac to
cabb92a
Compare
Author
|
Failures seem unrelated, rebasing and trying again.
|
Contributor
💚 Build Succeeded |
cabb92a to
99b60e8
Compare
Contributor
💚 Build Succeeded |
added 2 commits
September 16, 2019 09:18
99b60e8 to
90888b4
Compare
Contributor
💚 Build Succeeded |
ppisljar
approved these changes
Sep 17, 2019
Contributor
ppisljar
left a comment
There was a problem hiding this comment.
LGTM, tested in chrome linux
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
crob611
approved these changes
Sep 18, 2019
Contributor
crob611
left a comment
There was a problem hiding this comment.
Changes in Canvas look fine
stacey-gammon
pushed a commit
to stacey-gammon/kibana
that referenced
this pull request
Sep 19, 2019
* move actions to np * fix jest and types
friol
added a commit
to friol/kibana
that referenced
this pull request
Sep 19, 2019
stacey-gammon
pushed a commit
that referenced
this pull request
Sep 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Built on top of #44503. This moves the ui actions framework to the new platform. Other changes included:
Dev docs
The actions API that was previously a part of the Embeddable API is now it's own new platform plugin.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers