Move over to Google Storage vs AWS#44685
Move over to Google Storage vs AWS#44685joelgriffith merged 3 commits intoelastic:masterfrom joelgriffith:chore/move-chromium-builds-gcp
Conversation
|
Pinging @elastic/kibana-stack-services |
💚 Build Succeeded |
| export const paths = { | ||
| archivesPath: path.resolve(__dirname, '../../../.chromium'), | ||
| baseUrl: 'https://s3.amazonaws.com/headless-shell/', | ||
| baseUrl: 'https://storage.googleapis.com/headless_shell/', |
There was a problem hiding this comment.
would it be overkill to make this configurable?
There was a problem hiding this comment.
I'm leaning towards yes: the checksums make it impossible to implement this yourself (in the case of our users), and having different vendors for distributing this means having to maintain multiple places + another layer of debugging for services in case someone does something goofy. Honestly I don't envision this changing much so I'm ok with making it an application artifact versus a configuration artifact.
There was a problem hiding this comment.
Looks like we understand now that the baseUrl is only a factor in a dev and build environment :D
|
I think I lack the context for this. Is there an issue we can link in the description? |
💔 Build Failed |
💚 Build Succeeded |
Summary
Move our chromium builds to be served on Google Storage. I can see this potentially being a breaking change if users had previously whitelisted our old storage URL, so I might drop the 7.5.0 target if so otherwise I'd like to migrate over and start removing our older builds.