[test] consolidate top level yarn scripts#44679
Conversation
|
Pinging @elastic/kibana-operations |
💚 Build Succeeded |
💔 Build Failed |
|
@elasticmachine merge upstream |
💔 Build Failed |
| "start": "plugin-helpers start", | ||
| "test:server": "plugin-helpers test:server", | ||
| "test:browser": "plugin-helpers test:browser", | ||
| "test:mocha": "plugin-helpers test:server", |
There was a problem hiding this comment.
I find this redirection a bit confusing since we are calling these by the underlying test runner, where in plugin-helpers we are calling them by what they are testing.
Thoughts on changing those in plugin helpers? Or alias them there?
💔 Build Failed |
Over the last few years we've increased the number of test runners. Entry points by test type have become too lage of a category for unique names, so this moves top level test scripts under yarn and replaces test types with the runner name. e.g. `yarn test:browser` -> `yarn test:karma` Closes elastic#41133
|
#56014 upstream |
|
@elasticmachine merge upstream |
2 similar comments
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
sorry about the force push, only overwrote the elasticmachine merge |
|
@elastic/kibana-canvas is anyone available to take a look? https://github.com/elastic/kibana/pull/44679/files#diff-deb8813ae9843a9da52f812cba42f78d, short version is |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
@elasticmachine merge upstream |
|
cc canvas team again :) this shouldn't have any workflow impact, i'll be merging shortly. let me know |
|
@elasticmachine merge upstream |
* Refactor test entry by runner (#44679) Over the last few years we've increased the number of test runners. Entry points by test type have become too lage of a category for unique names, so this moves top level test scripts under yarn and replaces test types with the runner name. e.g. `yarn test:browser` -> `yarn test:karma` Closes #41133 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * fix merge Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
💔 Build FailedTest FailuresKibana Pipeline / kibana-intake-agent / Jest Integration Tests.packages/kbn-plugin-generator/integration_tests.running the plugin-generator via 'node scripts/generate_plugin.js plugin-name' with default config then running with es instance 'yarn start' should result in the spec plugin being initialized on kibana's stdoutStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_errors·js.discover app errors invalid scripted field error is renderedStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_errors·js.discover app errors invalid scripted field error is renderedStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
Over the last few years we've increased the number of test runners. Entry points by test type have become too lage of a category for unique names, so this moves top level test scripts under yarn and replaces test types with the runner name. e.g. `yarn test:browser` -> `yarn test:karma` Closes elastic#41133 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # packages/kbn-plugin-generator/sao_template/template/README.md # packages/kbn-plugin-helpers/lib/tasks.js # test/scripts/jenkins_xpack.sh
|
Backporting to 7.6 for consistency |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Dev Docs
Over time kibana has added a number of testing frameworks, but our top level scripts have remained the same to avoid workflow changes. The current naming convention with the number of test options can leave room for ambiguity.
This PR includes two general changes:
grunt/gulp -> node scripts/*)yarn test:server -> yarn test:mocha)Closes #41133