Move timefilter code ⇒ data plugin#44607
Merged
lizozom merged 12 commits intoelastic:masterfrom Sep 4, 2019
Merged
Conversation
added 5 commits
September 2, 2019 14:40
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
…ilter/move-data-1
Contributor
💔 Build Failed |
Contributor
|
Pinging @elastic/kibana-app-arch |
Contributor
💚 Build Succeeded |
lukeelmers
reviewed
Sep 3, 2019
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
Code LGTM, added two questions.
crob611
approved these changes
Sep 4, 2019
Contributor
crob611
left a comment
There was a problem hiding this comment.
Canvas changes look good 👍
…ilter/move-data-1
lukeelmers
approved these changes
Sep 4, 2019
Contributor
💚 Build Succeeded |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Sep 4, 2019
* import TimeRange from NP * Update imports * Update RefreshInterval imports to NP * Some more imports * Moved timefilter to data plugin (didn't rewire service!) * Fixed eslint error * remove virtual mock * kibana context import * Fix 'Monitoring is turned off' test * fix import
lizozom
pushed a commit
that referenced
this pull request
Sep 4, 2019
* import TimeRange from NP * Update imports * Update RefreshInterval imports to NP * Some more imports * Moved timefilter to data plugin (didn't rewire service!) * Fixed eslint error * remove virtual mock * kibana context import * Fix 'Monitoring is turned off' test * fix import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #44377
Moved
timefiltercode todataplugin folder.However, imports \ services are not rewired yet, to simplify PR!
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers