[Maps] Add attribution handling for TMS (config & UI-entry) and WMS#44147
Merged
kindsun merged 7 commits intoelastic:masterfrom Aug 29, 2019
Merged
[Maps] Add attribution handling for TMS (config & UI-entry) and WMS#44147kindsun merged 7 commits intoelastic:masterfrom
kindsun merged 7 commits intoelastic:masterfrom
Conversation
added 5 commits
August 26, 2019 13:12
Contributor
|
Pinging @elastic/kibana-gis |
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
|
retest |
Contributor
💚 Build Succeeded |
nickpeihl
approved these changes
Aug 28, 2019
Contributor
nickpeihl
left a comment
There was a problem hiding this comment.
minor nit, but otherwise lgtm
If possible can the order of attributions match the layer order in the TOC?
Contributor
Author
I can do that. I thought the same thing. That logic was already in place prior to this PR, I'll update it! |
Contributor
Author
|
retest |
3b033b9 to
d91dde7
Compare
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Aug 29, 2019
…lastic#44147) * Add attribution for tms from config * Add attribution entry fields & logic for tms from URL * Set text and url fields invalid if both aren't present * Don't return attribution unless both text and url defined * Add wms inputs & handling * Debounce input to prevent constantly generating new layers on keypress * Remove unapplicable placeholder text on WMS attribution inputs
kindsun
pushed a commit
that referenced
this pull request
Aug 29, 2019
…44147) (#44348) * Add attribution for tms from config * Add attribution entry fields & logic for tms from URL * Set text and url fields invalid if both aren't present * Don't return attribution unless both text and url defined * Add wms inputs & handling * Debounce input to prevent constantly generating new layers on keypress * Remove unapplicable placeholder text on WMS attribution inputs
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Aug 29, 2019
…lastic#44147) * Add attribution for tms from config * Add attribution entry fields & logic for tms from URL * Set text and url fields invalid if both aren't present * Don't return attribution unless both text and url defined * Add wms inputs & handling * Debounce input to prevent constantly generating new layers on keypress * Remove unapplicable placeholder text on WMS attribution inputs
This was referenced Aug 29, 2019
kindsun
pushed a commit
that referenced
this pull request
Aug 29, 2019
…44147) (#44411) * Add attribution for tms from config * Add attribution entry fields & logic for tms from URL * Set text and url fields invalid if both aren't present * Don't return attribution unless both text and url defined * Add wms inputs & handling * Debounce input to prevent constantly generating new layers on keypress * Remove unapplicable placeholder text on WMS attribution inputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing attribution for TMS and WMS layers. Resolves #32821 Previously we weren't showing attribution for TMS entered via config or via the Maps UI, or WMS. This PR adds attribution for each.
TMS via config
TMS via UI
http://c.tile.stamen.com/watercolor/{z}/{x}/{y}.jpg
WMS
https://www.gebco.net/data_and_products/gebco_web_services/web_map_service/mapserv?
