[SIEM] Apply tabs view on hosts and host details page with React Router#44037
Merged
angorayc merged 22 commits intoelastic:masterfrom Aug 29, 2019
Merged
[SIEM] Apply tabs view on hosts and host details page with React Router#44037angorayc merged 22 commits intoelastic:masterfrom
angorayc merged 22 commits intoelastic:masterfrom
Conversation
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
b75e5f9 to
dbea20b
Compare
Contributor
💔 Build Failed |
dbea20b to
bd78077
Compare
Contributor
💔 Build Failed |
Contributor
|
Pinging @elastic/siem |
2 tasks
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
x-pack/legacy/plugins/siem/public/components/navigation/breadcrumbs/index.test.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/components/navigation/breadcrumbs/index.test.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/components/navigation/breadcrumbs/index.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/components/navigation/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/components/navigation/tab_navigation/index.tsx
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
🤕 ouch...Never noticed we have to have a setTimeout of 500 milliseconds in order to narrow a date range.
Any comments to add about why we have to use this for maintainers in the code base?
I'm always nervous about the application of setTimeout's in a codebase.
Contributor
Author
There was a problem hiding this comment.
mm, I understand your concern. narrowDateRange here is consumed by chart, and in the implementation of elastic-chart is execute the event we passed first and then set the state for elastic-chart itself. If we don't wait until set state completed, it complains about setting state during render. That's the reason why setTimeout is here, but any suggestion are welcome.
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
745508e to
5c35c22
Compare
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
|
retest |
Contributor
|
test this |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Aug 29, 2019
…er (elastic#44037) * pass configs to tabs as props * split components into tab views * fix unit test * move navigations configs to new files * fix unit test * add tabsto host details * split tabs into routes * fix unit test * fix routing rules and bread crumb * fix type error * fix unit test * fix tab location * fix unit test * fix for reviews * rollback redundant change * fix for reviews * simplify logic for hosts redirect path * add reference for the issue of brush event
angorayc
added a commit
that referenced
this pull request
Aug 29, 2019
…er (#44037) (#44368) * pass configs to tabs as props * split components into tab views * fix unit test * move navigations configs to new files * fix unit test * add tabsto host details * split tabs into routes * fix unit test * fix routing rules and bread crumb * fix type error * fix unit test * fix tab location * fix unit test * fix for reviews * rollback redundant change * fix for reviews * simplify logic for hosts redirect path * add reference for the issue of brush event
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to move tables into tabs' body for hosts and hostDetails page and also update the bread crumb.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately