Replaced last import of chrome with core dep#44007
Merged
lizozom merged 6 commits intoelastic:masterfrom Aug 28, 2019
Merged
Conversation
Contributor
💔 Build Failed |
added 2 commits
August 27, 2019 09:32
Contributor
|
Pinging @elastic/kibana-app-arch |
added 2 commits
August 27, 2019 10:52
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Aug 28, 2019
* Replaced last import of chrome with core dep * pass saved objects client to FilterRow * update tests * fix warning * updated snapshot
streamich
approved these changes
Aug 28, 2019
Contributor
streamich
left a comment
There was a problem hiding this comment.
LGTM, tested on Mac/Chrome. Just one React comment below.
| intl: InjectedIntl; | ||
| uiSettings: UiSettingsClientContract; | ||
| savedQueryService: SavedQueryService; | ||
| savedObjectsClient: SavedObjectsClientContract; |
Contributor
There was a problem hiding this comment.
savedObjectsClient does not seem to change over time, thus it could be outside of state
private savedQueryService = createSavedQueryService(this.props.savedObjectsClient);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass
savedObjectsClientdown toQueryBarInputto remove the last import ofchromeindataplugin.I also moved the creation of
createSavedQueryServicefromtop_navtosearch_baras it led to a cleaner interface (as I would have had to pass down both.)Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers