[Code] Update download URLs for Java language server#43962
Merged
Poytr1 merged 2 commits intoelastic:masterfrom Aug 29, 2019
Merged
[Code] Update download URLs for Java language server#43962Poytr1 merged 2 commits intoelastic:masterfrom
Poytr1 merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/code |
zfy0701
approved these changes
Aug 26, 2019
Contributor
💚 Build Succeeded |
mw-ding
reviewed
Aug 26, 2019
Contributor
There was a problem hiding this comment.
kibana-plugins-plugins? 2 plugins in the folder name?
Contributor
Author
There was a problem hiding this comment.
It's caused by a release-manager issue: https://github.com/elastic/release-manager/pull/678#issuecomment-524906850. And it should be addressed soon, so I will update the URLs.
7615d57 to
5d891a6
Compare
Contributor
💚 Build Succeeded |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
Poytr1
pushed a commit
to Poytr1/kibana
that referenced
this pull request
Aug 29, 2019
Poytr1
pushed a commit
that referenced
this pull request
Aug 30, 2019
7 tasks
Poytr1
pushed a commit
to Poytr1/kibana
that referenced
this pull request
Sep 2, 2019
Poytr1
pushed a commit
that referenced
this pull request
Sep 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Because the change https://github.com/elastic/release-manager/pull/678 will put
java-langserverunder thekibana-pluginsfolder, so we need change the download URLs for Java language server.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers