[Infra UI] Add legends and points to charts on node detail page#43787
[Infra UI] Add legends and points to charts on node detail page#43787simianhacker merged 5 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/infra-logs-ui |
💚 Build Succeeded |
|
retest |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
@simianhacker , @phillipb can we align the charts and labels on this page?
I also think that a circle over each point could be smaller and thinner. Since we've already added Same^ goes for Metrics Explorer - the charts look excessively busy with points. Happy to create a new issue if it's more than just a quick fix.
|
|
We're facing the same alignment problems with elastic-charts on the log rate analysis page. If you come across a good solution we'd be interested to learn about it. |
|
@weltenwort @sorantis It's not possible because the Y-Axis legend labels are aligned "right" to the y-axis. Almost every charting system on the market will have this issue. The only way to make it look "aligned" is if we visually changed the size of the left padding (which won't work because our data is dynamic). The other option is to draw a container around the chart and then align to the container but allowing the y-axis labels enough room to grow and shrink based on the values. |
|
@sorantis I think we should leave the points as they are because it's becomes obvious when data is missing or if we only have 1 point; it favors accuracy over ascetics. If we want to move forward with this I would recommend opening a new issue so it doesn't get lost. |
|
related: #49393 |
Summary
This PR adds legends to the charts on the node detail page. This also increases the height of the charts by 50 pixels to make room for the legend on the system cpu chart. This PR also turns on the points for line and area charts so single points are easier to see.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibility