[ML] Anomaly Explorer: Updates dragSelect to 1.13.1. Fixes reload issue.#43779
Merged
walterra merged 4 commits intoelastic:masterfrom Aug 23, 2019
Merged
[ML] Anomaly Explorer: Updates dragSelect to 1.13.1. Fixes reload issue.#43779walterra merged 4 commits intoelastic:masterfrom
walterra merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💚 Build Succeeded |
alvarezmelissa87
approved these changes
Aug 22, 2019
Contributor
alvarezmelissa87
left a comment
There was a problem hiding this comment.
Gave this a test and LGTM ⚡️
Contributor
Author
|
retest |
Contributor
Author
|
Created a PR on EUI to fix the issue in |
Contributor
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Aug 23, 2019
…ue. (elastic#43779) - Updates the dragSelect library to 1.13.1. 9221622 updates the library. c9a870b fixes a regression caused by the update. - Fixes an issue where a timefilter refresh would clear a swimlane selection. 3d1c43d removes a duplicate timefilter subscription and changes the triggered event to REDRAW instead of RELOAD (which triggered a full reload and cleared the selection). - Fixes an issue with timefilter/datepicker: EuiSuperDatePicker checks isPaused only with componentDidMount() so it might miss changing props. The fix in aa9555d works around that by adding a check on the onRefresh() callback.
walterra
added a commit
that referenced
this pull request
Aug 23, 2019
…ue. (#43779) (#43846) - Updates the dragSelect library to 1.13.1. 9221622 updates the library. c9a870b fixes a regression caused by the update. - Fixes an issue where a timefilter refresh would clear a swimlane selection. 3d1c43d removes a duplicate timefilter subscription and changes the triggered event to REDRAW instead of RELOAD (which triggered a full reload and cleared the selection). - Fixes an issue with timefilter/datepicker: EuiSuperDatePicker checks isPaused only with componentDidMount() so it might miss changing props. The fix in aa9555d works around that by adding a check on the onRefresh() callback.
This was referenced Sep 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #38266.
REDRAWinstead ofRELOAD(which triggered a full reload and cleared the selection).EuiSuperDatePickerchecksisPausedonly withcomponentDidMount()so it might miss changing props. The fix in aa9555d works around that by adding a check on theonRefresh()callback.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers