Remove code for handling .zip files#43764
Merged
jfsiii merged 1 commit intoelastic:feature-integrations-managerfrom Aug 22, 2019
jfsiii:43761-remove-zip-support
Merged
Remove code for handling .zip files#43764jfsiii merged 1 commit intoelastic:feature-integrations-managerfrom jfsiii:43761-remove-zip-support
jfsiii merged 1 commit intoelastic:feature-integrations-managerfrom
jfsiii:43761-remove-zip-support
Conversation
Contributor
|
Pinging @elastic/infra-logs-ui |
ruflin
approved these changes
Aug 22, 2019
Contributor
ruflin
left a comment
There was a problem hiding this comment.
Always 👍 on removing code and dependencies. I assume yauzl is also used in other places so it can't be removed.
Contributor
💚 Build Succeeded |
Contributor
Author
Only one place that I know of, but yes |
1 task
jfsiii
pushed a commit
that referenced
this pull request
Sep 1, 2020
* Quick pass at restoring support for both zip & tar Restored unzip functions from #43764 Persist the `download` value returned by EPR (e.g. `/epr/system/system-0.5.3.zip` or `/epr/system/system-0.5.3.tar.gz`) as "archive key" for a package name/version combo. The same name&version should return the same archive. The value initially given by the registry. Based on that value, we decide which decompression to use. * Use template literal vs JSON.stringify for keygen * Factor unzip/untar logic out to getBufferExtractor * Add tests for getBufferExtractor * Replace `[aA]rchiveKey*` with `[aA]rchiveLocation*` * Include given name & version in error message Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jfsiii
pushed a commit
that referenced
this pull request
Sep 2, 2020
… (#76485) * Quick pass at restoring support for both zip & tar Restored unzip functions from #43764 Persist the `download` value returned by EPR (e.g. `/epr/system/system-0.5.3.zip` or `/epr/system/system-0.5.3.tar.gz`) as "archive key" for a package name/version combo. The same name&version should return the same archive. The value initially given by the registry. Based on that value, we decide which decompression to use. * Use template literal vs JSON.stringify for keygen * Factor unzip/untar logic out to getBufferExtractor * Add tests for getBufferExtractor * Replace `[aA]rchiveKey*` with `[aA]rchiveLocation*` * Include given name & version in error message Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/ingest_manager/server/services/epm/registry/cache.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #43761