Skip to content

Restructure vis plugin & export types contracts#43730

Closed
lukeelmers wants to merge 2 commits intoelastic:masterfrom
lukeelmers:feat/vis-move
Closed

Restructure vis plugin & export types contracts#43730
lukeelmers wants to merge 2 commits intoelastic:masterfrom
lukeelmers:feat/vis-move

Conversation

@lukeelmers
Copy link
Copy Markdown
Contributor

This picks up the work that was started in #35625 and does the following:

  • Updates structure of vis plugin for consistency with our shimming conventions
  • Ensures public contracts from ui/vis that need to live in the visualizations plugin are re-exported

Next steps:

  • Actually move the code and re-export legacy contracts from ui/vis
  • Deangularization, more TS conversion, etc

@lukeelmers lukeelmers added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v8.0.0 Team:AppArch v7.4.0 Feature:NP Migration labels Aug 22, 2019
@lukeelmers lukeelmers requested a review from ppisljar August 22, 2019 00:20
@lukeelmers lukeelmers self-assigned this Aug 22, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app-arch

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@lukeelmers
Copy link
Copy Markdown
Contributor Author

closing in favor of #44839

@lukeelmers lukeelmers closed this Sep 4, 2019
@lukeelmers lukeelmers deleted the feat/vis-move branch September 4, 2019 23:52
lukeelmers added a commit to lukeelmers/kibana that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:NP Migration Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v7.4.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants