ui/saved_objects components -> New Platform#43416
Merged
streamich merged 11 commits intoelastic:masterfrom Aug 30, 2019
streamich:refactor/saved_objects
Merged
ui/saved_objects components -> New Platform#43416streamich merged 11 commits intoelastic:masterfrom streamich:refactor/saved_objects
streamich merged 11 commits intoelastic:masterfrom
streamich:refactor/saved_objects
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch |
Contributor
Author
|
Closes #42865 |
lukeelmers
approved these changes
Aug 19, 2019
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
Overall makes sense, but we should document the fact that we also changed the component contract here to take in stateful services as props.
Even though you did this in a way that's backwards compatible for folks importing from ui/public, it still feels like something we should have in the shared dev docs issue so people know that it isn't simply a matter of changing their imports.
rudolf
reviewed
Aug 19, 2019
src/legacy/ui/public/saved_objects/components/saved_object_save_modal.tsx
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
rudolf
approved these changes
Aug 27, 2019
Contributor
rudolf
left a comment
There was a problem hiding this comment.
👍
I think it's low enough risk and effort to update the old import paths and delete src/legacy/ui/public/saved_objects/components/saved_object_save_modal.tsx but that can be done in a separate PR.
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
streamich
added a commit
that referenced
this pull request
Aug 30, 2019
* refactor: 💡 remove chrome usage in ui/saved_objects * refactor: 💡 move <SavedObjectFinder> to kibana-react NP plugin * test: 💍 move <SavedObjectFinder> tests to New Platform * refactor: 💡 move <SavedObjectSaveModal> to kibana-react plugin * test: 💍 fix TypeScript errors in a test * feat: 🎸 port translations to NP plugin * test: 💍 update Jest snapshot
Contributor
💔 Build Failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui/saved_objectstokibana_reactNew Platform plugin.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers
Dev Docs
Saved objects React components
<SavedObjectFinder>and<SavedObjectSaveModal>React components have been moved tokibana_reactNew Platform plugin. Usage of the new components: