Consistent positioning of Timepicker in SearchBar#43255
Merged
lizozom merged 2 commits intoelastic:masterfrom Aug 15, 2019
Merged
Consistent positioning of Timepicker in SearchBar#43255lizozom merged 2 commits intoelastic:masterfrom
lizozom merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch |
11 tasks
Contributor
💚 Build Succeeded |
cchaos
previously requested changes
Aug 14, 2019
Contributor
cchaos
left a comment
There was a problem hiding this comment.
There's actually no need to add a custom style for this. The .kbnQueryBar is an EuiFlexGroup component which accepts justifyContent="flexEnd".
|
I checked and played with the PR LGTM, thanks @lizozom |
Contributor
Author
|
@cchaos done |
Contributor
💚 Build Succeeded |
ryankeairns
approved these changes
Aug 15, 2019
Contributor
ryankeairns
left a comment
There was a problem hiding this comment.
LGTM. Reviewed the change requested by Caroline (who is out) and it looks good.
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Aug 15, 2019
lizozom
pushed a commit
that referenced
this pull request
Aug 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align SearchBar \ Time picker to the right
Resolves #41900
In apps where SearchBar only contains Timepicker, it looks like this:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers