[ML] Adds DF Transform Analytics list to Kibana management#43151
Conversation
|
Pinging @elastic/ml-ui |
💔 Build Failed |
💔 Build Failed |
473672d to
edd9ca9
Compare
💔 Build Failed |
💚 Build Succeeded |
walterra
left a comment
There was a problem hiding this comment.
Looks good overall! Added some questions about naming.
x-pack/legacy/plugins/ml/public/jobs/jobs_list/components/jobs_list/jobs_list.js
Outdated
Show resolved
Hide resolved
|
|
||
| export const DataFrameAnalyticsList: FC = () => { | ||
| interface Props { | ||
| isManagementTable?: boolean; |
There was a problem hiding this comment.
Naming nit: I'm afraid isManagementTable could be a bit confusing. It refers to the management section in Kibana, but seen alone here like this "management" could mean the opposite as in the capability to manage jobs where the table in Kibana management is view only. I'd like to suggest that we rename it to something that refers to the feature that the flag will enable/disable, something like isReadOnly or hideActions, what do you think?
There was a problem hiding this comment.
Good point. 🤔 I'm not sure isReadOnly or something like that would fit since it's more that we're showing a different level of detail as well as removing actions when it's for the Kibana management view. This is the same prop name used in for the job management table so it would be consistent. Happy to change to something that makes more sense. Maybe in a small follow-up once we've decided on a name?
...k/legacy/plugins/ml/public/management/jobs_list/components/jobs_list_page/_expanded_row.scss
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
There was a problem hiding this comment.
Can you make an issue in EUI surrounding the problem you encountered so we can make the fix over there?
…43321) * disable job link if ml not enabled in space * add analytics table in managment page * update css for analytics table * only show ML section if license if trial/platinum * remove actions column for analytics list in KM * fix typescript error on columns * update props interface for analytics table * plain text instead of disabled link if not enabled in space
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (50 commits) [Uptime] update monitor list configs for mobile view (elastic#43218) [APM] Local UI filters (elastic#41588) [Code] Upgrade ctags langserver (elastic#43252) [Code] show multiple definition results in panel (elastic#43249) Adds Metric Type to full screen launch tracking (elastic#42692) [Canvas] Convert Autocomplete to Typescript (elastic#42502) [telemetry] add spacesEnabled config back to xpack_main (elastic#43312) [ML] Adds DF Transform Analytics list to Kibana management (elastic#43151) Add TLS client authentication support. (elastic#43090) [csp] Telemetry for csp configuration (elastic#43223) [SIEM] Run Cypress Tests Against Elastic Cloud & Cypress Command Line / Reporting (elastic#42804) docs: add tip on agent config in a dt (elastic#43301) [ML] Adding bucket span estimator to new wizards (elastic#43288) disable flaky tests (elastic#43017) Fix percy target branch for PRs (elastic#43160) [ML] Adding post create job options (elastic#43205) Restore discover histogram selection triggering fetch (elastic#43097) Per panel time range (elastic#43153) [Infra UI] Add APM to Metadata Endpoint (elastic#42197) Sentence case copy changes (elastic#43215) ...
Summary
This PR is a follow up to #42570
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenariosFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately