Expose task manager as plugin instead of server argument#42966
Merged
mikecote merged 3 commits intoelastic:masterfrom Aug 9, 2019
Merged
Expose task manager as plugin instead of server argument#42966mikecote merged 3 commits intoelastic:masterfrom
mikecote merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-stack-services |
Contributor
💚 Build Succeeded |
bmcconaghy
reviewed
Aug 9, 2019
Contributor
bmcconaghy
left a comment
There was a problem hiding this comment.
Noticed some places where we're not handling that the task_manager plugin could be disabled.
x-pack/legacy/plugins/maps/server/maps_telemetry/maps_usage_collector.js
Show resolved
Hide resolved
|
|
||
| export function registerMapsTelemetryTask(server) { | ||
| const taskManager = server.taskManager; | ||
| const taskManager = server.plugins.task_manager; |
Contributor
There was a problem hiding this comment.
Same here, should check for null.
Member
There was a problem hiding this comment.
Just checking in on the changes, which LGTM
A null check for this might be moot to do from the maps plugin, since the plugin definition requires task_manager: 55e7b183d75#diff-1bb2390b8f55e83f3a830c385a7d664eR21
It's odd that part ^^ worked before this PR
|
|
||
| export function registerTasks(server: HapiServer) { | ||
| const { taskManager } = server; | ||
| const taskManager = server.plugins.task_manager; |
Contributor
There was a problem hiding this comment.
same here re: null check
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Aug 9, 2019
* Expose task manager as plugin instead of server attribute * Cleanup * Fix typo
mikecote
added a commit
that referenced
this pull request
Aug 9, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 12, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (22 commits) [Code]: downgrade the log level of error message from subprocess (elastic#42925) [Code] Cancel clone/update job in the middle if disk space over the watermark (elastic#42890) Add Kibana App specific URL to the help menu (elastic#34739) (elastic#42580) [Maps] refactor createShapeFilterWithMeta to support more than just polygons (elastic#43042) Skip flaky es_ui_shared/request tests. Pass uiSettings to all data plugin services (elastic#42159) [SIEM] Upgrades react-redux and utilize React.memo for performance gains (elastic#43029) [skip-ci][Maps] add maki icon sheet to docs (elastic#43063) Adding "style-src 'unsafe-inline' 'self'" to default CSP rules (elastic#41305) Update dependency commander to v3 (elastic#43041) Update dependency @percy/agent to ^0.10.0 (elastic#40517) [Maps] only show top hits checkbox if index has date fields (elastic#43056) run chained_controls on Firefox to catch regression (elastic#43044) fixing issue with dashboard csv download (elastic#42964) Expose task manager as plugin instead of server argument (elastic#42966) Expose createRouter from HttpService, prepare handlers for context introduction (elastic#42686) [Code] disk watermark supports percentage and absolute modes (elastic#42987) [apps/dashboard] skip part of filtering tests on FF (elastic#43047) [ML] Kibana management jobs list (elastic#42570) [ML] Fix check for watcher being enabled (elastic#43025) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the new platform migration, task manager should be exposed as a plugin instead of an attribute on the server (
server.plugins.task_managerinstead ofserver.taskManager).This PR converts the task manager to be exposed as a plugin. This also converts
task_manager/index.jsto typescript to leverage typescript checks to ensure all task manager functions are exposed.