[ML] Adding job overrides to the module setup endpoint#42946
Merged
jgowdyelastic merged 4 commits intoelastic:masterfrom Aug 9, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💔 Build Failed |
Member
Author
|
retest |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
x-pack/legacy/plugins/ml/server/models/data_recognizer/data_recognizer.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/server/models/data_recognizer/data_recognizer.js
Outdated
Show resolved
Hide resolved
alvarezmelissa87
approved these changes
Aug 8, 2019
Contributor
alvarezmelissa87
left a comment
There was a problem hiding this comment.
LGTM overall 👍 - just added a couple of small comments
walterra
approved these changes
Aug 9, 2019
x-pack/legacy/plugins/ml/server/models/data_recognizer/data_recognizer.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/server/models/data_recognizer/data_recognizer.js
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Aug 9, 2019
* [ML] Adding job overrides to the module setup endpoint * removing text code * throw error for incompatible data * changes based on review
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 9, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (306 commits) [ML] Adding job overrides to the module setup endpoint (elastic#42946) [APM] Fix missing RUM url (elastic#42940) close socket timeouts without message (elastic#42456) Upgrade elastic/charts to 8.1.6 (elastic#42518) [ML] Delete old AngularJS data visualizer and refactor folders (elastic#42962) Add custom formatting for Date Nanos Format (elastic#42445) [Vega] Shim new platform - vega_fn.js -> vega_fn.js , use ExpressionFunction (elastic#42582) add socket.getPeerCertificate to KibanaRequest (elastic#42929) [Automation] ISTANBUL PRESET PATH is not working fine with constructor(private foo) (elastic#42683) [ML] Data frames: Updated stats structure. (elastic#42923) [Code] fixed the issue that the repository can not be deleted in some cases. (elastic#42841) [kbn-es] Support for passing regex value to ES (elastic#42651) Connect to Elasticsearch via SSL when starting kibana with `--ssl` (elastic#42840) Add Elasticsearch SSL support for integration tests (elastic#41765) Fix duplicate fetch in Visualize (elastic#41204) [DOCS] TSVB and Timelion clean up (elastic#42953) [Maps] [File upload] Fix maps geojson upload hanging on index step (elastic#42623) [APM] Use rounded bucket sizes for transaction distribution (elastic#42830) [yarn.lock] consistent resolve domain (elastic#42969) [Uptime] [Test] Repurpose unit test assertions to avoid flakiness (elastic#40650) ...
jgowdyelastic
added a commit
that referenced
this pull request
Aug 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to supply the
/api/ml/modules/setup/{moduleId}endpoint with job and datafeed overrides in the form or partial job and datafeed configurations.e.g. this will apply
model_memory_limit: 13mbto all jobs in the module.The overrides can be a single object or array of objects. If the object contains a
job_idordatafeed_id, the overrides contained in that object will only be applied to the matching job or datafeed in the module.If no id is specified, the overrides in the object will be applied to all jobs or datafeeds in the module.
The below example will set the
bucket_spanto15min all jobs and themodel_memory_limitto13mbfor the jobvisitor_rate_ecsIt will also set the
scroll_sizeto1001for all datafeeds and thefrequencyto30mfor the datafeed for the jobvisitor_rate_ecsRather than using the
job_idin the datafeed, you could also have used:"datafeed_id": "datafeed-visitor_rate_ecs"These overrides are applied before any of the existing overridable options (e.g.
useDedicatedIndex,groups,indexPatternNameetc) and so can be overridden themselves.In the below example, the
match_allquery will be used over thequerypassed in via thedatafeedOverridesFunctional tests are needed for this change, which will be added in a follow up PR.
cc @weltenwort
Fixes #42409
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers