Expose spaces plugin function signatures in TypeScript#42133
Merged
mikecote merged 2 commits intoelastic:masterfrom Jul 30, 2019
Merged
Expose spaces plugin function signatures in TypeScript#42133mikecote merged 2 commits intoelastic:masterfrom
mikecote merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-security |
This comment has been minimized.
This comment has been minimized.
legrego
reviewed
Jul 30, 2019
x-pack/legacy/plugins/security/server/lib/authorization/check_privileges_dynamically.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Jul 30, 2019
* Expose spaces plugin function signatures * Apply PR feedback
mikecote
added a commit
that referenced
this pull request
Jul 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I'm adding missing functions into the
SpacesPluginTypeScript definition.The need for me started when I need to pass
spaceIdToNamespace&getBasePathfunctions around and wanted to re-use TypeScript signatures (#42081).