Put filters back in the filter context where they belong#42095
Merged
Bargs merged 6 commits intoelastic:masterfrom Aug 1, 2019
Merged
Put filters back in the filter context where they belong#42095Bargs merged 6 commits intoelastic:masterfrom
Bargs merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
lukasolson
approved these changes
Aug 1, 2019
Contributor
lukasolson
left a comment
There was a problem hiding this comment.
LGTM code/functionality.
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Aug 1, 2019
Filters were never really meant to take part in scoring in the first place. This PR puts filters back in the filter context where they were in 4.x so they can benefit from the filter cache.
Bargs
added a commit
that referenced
this pull request
Aug 2, 2019
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8367
As this comment makes very clear, filters were never really meant to take part in scoring in the first place. This PR puts filters back in the filter context where they were in 4.x so they can benefit from the filter cache.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately