Issue 28471: Added strict id checking#40673
Merged
igoristic merged 7 commits intoelastic:masterfrom Jul 16, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/stack-monitoring |
Contributor
💚 Build Succeeded |
Contributor
|
Have you looked into adding a test for this? |
Contributor
chrisronline
left a comment
There was a problem hiding this comment.
Functionally, this LGTM!
I ran a script to manually make the primary storage size smaller than the total and observed the broken behavior and then saw the fixed behavior with this PR. Great job!
Contributor
💚 Build Succeeded |
Contributor
|
Per our discussion in slack, let's convert this unit test into a jest test by renaming the test file to |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
igoristic
added a commit
to igoristic/kibana
that referenced
this pull request
Jul 16, 2019
* Added a strict id check * Added unit tests * Converted unit tests to jest
igoristic
added a commit
to igoristic/kibana
that referenced
this pull request
Jul 16, 2019
* Added a strict id check * Added unit tests * Converted unit tests to jest
Contributor
Author
igoristic
added a commit
to igoristic/kibana
that referenced
this pull request
Jul 16, 2019
* Added a strict id check * Added unit tests * Converted unit tests to jest
igoristic
added a commit
that referenced
this pull request
Jul 16, 2019
igoristic
added a commit
that referenced
this pull request
Jul 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #28471
Summary
The current implementation was only checking if the first word matches thus:
StoresandStores (Primaries)would always match.This was hard to reproduce, because usually Store sizes lineup perfectly behind each other and
Stores (Primaries)would always coverStores, so there was no way to see which toggle state it was in. I randomized the data a little to be able to distinguish them.