Expose "is TLS enabled" flag for Kibana HTTP Server#40336
Merged
mshustov merged 5 commits intoelastic:masterfrom Jul 9, 2019
Merged
Expose "is TLS enabled" flag for Kibana HTTP Server#40336mshustov merged 5 commits intoelastic:masterfrom
mshustov merged 5 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-platform |
Contributor
💚 Build Succeeded |
10 tasks
Contributor
💚 Build Succeeded |
joshdover
approved these changes
Jul 9, 2019
Contributor
joshdover
left a comment
There was a problem hiding this comment.
LGTM, just a small naming nit
src/core/server/http/http_server.ts
Outdated
| isAuthenticated: AuthStateStorage['isAuthenticated']; | ||
| getAuthHeaders: AuthHeadersStorage['get']; | ||
| }; | ||
| isTLSEnabled: boolean; |
Contributor
There was a problem hiding this comment.
I think this should be capitalized isTlsEnabled to be consistent with HttpServer and SslConfig
Contributor
💚 Build Succeeded |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Jul 9, 2019
* expose it TLS enabled on Http server * setup contract is under one section in tests * regenerate docs * isTLSEnabled --> isTlsEnabled
mshustov
added a commit
that referenced
this pull request
Jul 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose boolean flag indicating if TLS enabled for Kibana HTTP server.
The frist commit introduces flag.
The second one restructures tests to move all
setup contractrelated tests under one section.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers