Skip to content

[DOCS] Updates Watcher docs to match updated UI#40106

Merged
gchaps merged 5 commits intoelastic:masterfrom
gchaps:docs/watcher-update
Jul 9, 2019
Merged

[DOCS] Updates Watcher docs to match updated UI#40106
gchaps merged 5 commits intoelastic:masterfrom
gchaps:docs/watcher-update

Conversation

@gchaps
Copy link
Copy Markdown
Contributor

@gchaps gchaps commented Jul 1, 2019

Summary

This PR updates the Watcher docs to match the revisions in the UI

[skip ci]

@gchaps gchaps requested a review from lcawl July 1, 2019 23:12
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-docs

Copy link
Copy Markdown
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 2 very small comments. But other than these, this LGTM.

==== Add an action

Click `Add new action` to trigger a dropdown selection:
Now that the condition is set, you must define an action. The action triggers
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

define or add?

[[watcher-getting-started]]
=== View watch history and status
The Watcher overview page lists all your watches,
including their state: `Firing`, `Error`, `OK`, or `Disabled`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not for this PR, but it would be cool if these states were defined. For example, I'm not 100% sure what Firing means.

== Watcher UI
== Watcher

Watcher is an {es} feature that you can use to create actions based on
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in general we're not using "Watcher" as much anymore. If you look on https://www.elastic.co/subscriptions and https://www.elastic.co/products/stack/alerting it's not mentioned there.

I recommend using the alert-features attribute from https://github.com/elastic/docs/blob/master/shared/attributes.asciidoc

For example:

Suggested change
Watcher is an {es} feature that you can use to create actions based on
The {alert-features} enable you to create actions based on

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that this section only applies when security features are enabled, so it's a good idea to add that qualification. For example:

Suggested change
To use Watcher, you must have the built-in `kibana_user` role.
If the {es} {security-features} are enabled, to use {alert-features} in {kib}, you must have the built-in `kibana_user` role.

Copy link
Copy Markdown
Contributor

@lcawl lcawl Jul 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You must also have one of the following Watcher roles:
You must also have one of the following {stack-ov}/built-in-roles.html[built-in roles]:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we're describing security requirements, we often start by saying which privileges they require (e.g. manage_watcher or monitor_watcher cluster privileges per https://www.elastic.co/guide/en/elastic-stack-overview/master/security-privileges.html . Then we mention the built-in roles in case they don't want to add these privileges to their existing roles.

Copy link
Copy Markdown
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment about terminology but otherwise it builds successfully and LGTM

@gchaps gchaps force-pushed the docs/watcher-update branch from d55d472 to 797a6ff Compare July 9, 2019 18:46
@gchaps gchaps requested a review from lcawl July 9, 2019 18:51
@gchaps gchaps merged commit 504dfba into elastic:master Jul 9, 2019
@gchaps gchaps deleted the docs/watcher-update branch July 9, 2019 19:04
gchaps added a commit that referenced this pull request Jul 9, 2019
* [DOCS] Updates Watcher docs to match updated UI

* [DOCS] Incoporates watcher review comments and adds badge

* [DOCS] Updated watcher security doc based on feedback

* Update docs/management/watcher-ui/index.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
gchaps added a commit that referenced this pull request Jul 9, 2019
* [DOCS] Updates Watcher docs to match updated UI

* [DOCS] Incoporates watcher review comments and adds badge

* [DOCS] Updated watcher security doc based on feedback

* Update docs/management/watcher-ui/index.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants