[core] Support x-pack plugins in new platform#39454
Merged
joshdover merged 5 commits intoelastic:masterfrom Jun 24, 2019
Merged
[core] Support x-pack plugins in new platform#39454joshdover merged 5 commits intoelastic:masterfrom
joshdover merged 5 commits intoelastic:masterfrom
Conversation
Unless Kibana is running as oss-only, the x-pack plugins path is configured in the environment for use in plugin discovery.
Contributor
|
Pinging @elastic/kibana-platform |
This comment has been minimized.
This comment has been minimized.
joshdover
approved these changes
Jun 21, 2019
Contributor
joshdover
left a comment
There was a problem hiding this comment.
Tested with copying the testbed plugin to x-pack and it worked 👍
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
retest |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
joshdover
pushed a commit
to joshdover/kibana
that referenced
this pull request
Jun 24, 2019
* Include x-pack plugin path when appropriate Unless Kibana is running as oss-only, the x-pack plugins path is configured in the environment for use in plugin discovery.
joshdover
added a commit
that referenced
this pull request
Jun 24, 2019
Contributor
|
@epixa can you please add a Dev Doc section to the PR for the API changes blog? |
Contributor
Author
|
@rayafratkina This isn't relevant to plugin developers as it only pertains to code in the Kibana repo which has already been updated to support the change, so I've switched this to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unless Kibana is running as oss-only, the x-pack plugins path is
configured in the environment for use in plugin discovery.
Closes #39447