[savedObjects] change the number mappings to be 'long'#3913
Merged
rashidkpc merged 1 commit intoelastic:masterfrom May 21, 2015
Merged
[savedObjects] change the number mappings to be 'long'#3913rashidkpc merged 1 commit intoelastic:masterfrom
rashidkpc merged 1 commit intoelastic:masterfrom
Conversation
Since JavaScript numbers can't actually be integers we don't really care about the difference between int and long, but since the long is the default type it makes things more frictionless
rashidkpc
added a commit
that referenced
this pull request
May 21, 2015
[savedObjects] change the number mappings to be 'long'
|
The released version of 4.3.0 contains this bug (the fix is missing) |
|
+1, it's the same for master |
Contributor
Author
|
Yes, this was reverted in 39f56d6 because of the unintented side effects it caused. We can't simply change the mapping we send to elasticsearch without providing a migration of some sort for existing mappings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3882
The import currently doesn't set the mapping for saved objects, but it really doesn't
need to since all of the field types match the defaults for their contents. This aligns
hits:andversion:fields with the defaults as well.Opened #3912 to provide a more future-proof solution.