[Core] Move Saved objects files to core#38771
Merged
rudolf merged 9 commits intoelastic:masterfrom Jun 18, 2019
Merged
Conversation
3596fbd to
0b7a0df
Compare
Contributor
💚 Build Succeeded |
Contributor
|
Pinging @elastic/kibana-platform |
Contributor
💚 Build Succeeded |
b59a1ca to
514e79b
Compare
Contributor
💚 Build Succeeded |
legrego
approved these changes
Jun 14, 2019
Member
legrego
left a comment
There was a problem hiding this comment.
Changes for spaces and encrypted_saved_objects LGTM!
mshustov
reviewed
Jun 14, 2019
src/core/server/server.api.md
Outdated
| delete(type: string, id: string, options?: SavedObjectsBaseOptions): Promise<{}>; | ||
| // (undocumented) | ||
| errors: { | ||
| isSavedObjectsClientError: typeof import("./lib/errors").isSavedObjectsClientError; |
Contributor
There was a problem hiding this comment.
1 nit: not really useful typings
2 expose the same things as a class property and class static property can be confusing for customers
Contributor
Author
There was a problem hiding this comment.
- I've addressed this by creating a
SavedObjectsErrorHelpersclass so that the type documentation is better. - Because of the way I type
SavedObjectsClientContractthe staticerrorsproperty isn't included in the type. So when I remove thepublic errorsthere's a lot of type errors even though this should technically resolve to the static function. I can probably fix this by creating aSavedObjectsClientContractinterface and duplicating the types from the class. However, becauseSavedObjectsErrorHelpersis just static functions, I've been thinking of removing these convenienceerrorsproperties and instead let consumers rather importSavedObjectsErrorHelpersdirectly. Because this is a breaking API change, I'd prefer to do this in a separate PR.
dgieselaar
approved these changes
Jun 17, 2019
Contributor
dgieselaar
left a comment
There was a problem hiding this comment.
LGTM, based on the assumption that this is just type/file changes.
Contributor
💔 Build Failed |
joshdover
approved these changes
Jun 17, 2019
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
rudolf
added a commit
that referenced
this pull request
Jun 18, 2019
* Move src/legacy/server/saved_objects -> src/core/server/saved_objects * Fix SavedObject import references after moving files to core * First pass at SavedObjects api docs * Expose and import all saved object types through core/server * Don't expose SavedObjectsManagement from core and fix imports * Improve typings for SavedObject error helpers * Fix type errors after master merge * Fix SavedObjectErrorHelpers tests
rudolf
added a commit
that referenced
this pull request
Jun 19, 2019
* Move src/legacy/server/saved_objects -> src/core/server/saved_objects * Fix SavedObject import references after moving files to core * First pass at SavedObjects api docs * Expose and import all saved object types through core/server * Don't expose SavedObjectsManagement from core and fix imports * Improve typings for SavedObject error helpers * Fix type errors after master merge * Fix SavedObjectErrorHelpers tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the first phase of exposing Saved Objects client from Core.
src/legacy/server/saved_objects/->src/core/server/saved_objects.src/core/serversrc/core/server/saved_objectsto ease the migration.