Beats management: Remove obsolete type overrides#37624
Merged
flash1293 merged 1 commit intoelastic:masterfrom Jun 3, 2019
Merged
Beats management: Remove obsolete type overrides#37624flash1293 merged 1 commit intoelastic:masterfrom
flash1293 merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/beats |
Contributor
💚 Build Succeeded |
mattapperson
approved these changes
Jun 3, 2019
|
Intentional this isn't going to be backported? |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Jun 18, 2019
flash1293
added a commit
that referenced
this pull request
Jun 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
x-pack/plugins/beats_management/types/kibana.d.tstypes for some JS only OSS dependencies were provided. In the meantime, these things are completely typed within the OSS code base itself (src/legacy/ui/public/autocomplete_providers/index.d.ts) and have diverged slightly.This PR removes the overrides which causes the compiler to transparently use the upstream typings.
Context: I got aware of this because the differences in typings cause an error if OSS types are relatively imported from within x-pack plugins.