[Canvas] Fix workpad list overflow#37345
Merged
ryankeairns merged 3 commits intoelastic:masterfrom Jun 4, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-canvas |
Contributor
💚 Build Succeeded |
cqliu1
approved these changes
May 29, 2019
Contributor
cqliu1
left a comment
There was a problem hiding this comment.
LGTM 👍
Is there anyway we can make the filepicker full width here on small screens? It looks a little odd, but you don't have to address it in this PR.
Contributor
Author
|
@cqliu1 made the file picker full width on small screens. |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
c235e60 to
805dce2
Compare
Contributor
💔 Build Failed |
805dce2 to
c5e0ee4
Compare
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
c5e0ee4 to
4d6f1b9
Compare
w33ble
approved these changes
May 30, 2019
Contributor
w33ble
left a comment
There was a problem hiding this comment.
Confirmed fixed on the home screen and the modal view 👍
Contributor
💚 Build Succeeded |
snide
suggested changes
May 30, 2019
Contributor
snide
left a comment
There was a problem hiding this comment.
Some small stuff. I'd check on your modal. Likely some small fixes there to get it working correct.
x-pack/plugins/canvas/public/components/workpad_loader/workpad_loader.scss
Outdated
Show resolved
Hide resolved
x-pack/plugins/canvas/public/components/workpad_manager/workpad_manager.js
Outdated
Show resolved
Hide resolved
Contributor
💔 Build Failed |
e0f0982 to
2346210
Compare
Contributor
💚 Build Succeeded |
Contributor
Author
|
@snide when you have a minute, can you re-check this one quick. I made some small changes based upon your requested changes. |
snide
approved these changes
Jun 3, 2019
Contributor
snide
left a comment
There was a problem hiding this comment.
checked the latest locally. LGTM
jgowdyelastic
pushed a commit
that referenced
this pull request
Jun 4, 2019
* fix workpad list overflow * make file picker full width on small devices * fix modal height, add comments
ryankeairns
added a commit
to ryankeairns/kibana
that referenced
this pull request
Jun 5, 2019
* fix workpad list overflow * make file picker full width on small devices * fix modal height, add comments
ryankeairns
added a commit
to ryankeairns/kibana
that referenced
this pull request
Jun 5, 2019
* fix workpad list overflow * make file picker full width on small devices * fix modal height, add comments
ryankeairns
added a commit
that referenced
this pull request
Jun 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24773
Summary
Prevent the workpad list from overflowing its parent panel on smaller devices.
The issue here is that we're using
euiModalstyles to present what is actually page body content. On smaller devices, modals (.euiModalBody) are set to100vwso that they take up the full viewport width.The quick fix here is to just override that rule in this particular case. Swapping out for a panel, while more correct, comes with other issues as this same markup is presented as a modal when you open the workpad switcher from the workpad/page view as opposed to opening it from the home page.
Viewed at < 768px
Checklist