Remove duplicate fields of rollup based index patterns#37221
Remove duplicate fields of rollup based index patterns#37221kertal merged 1 commit intoelastic:masterfrom
Conversation
since the fields are already part of the merged version this is the cause for displaying duplicates in the index pattern
|
Pinging @elastic/kibana-app |
|
Since this is a bugfix, is this worth backporting to 7.2? |
cjcenizal
left a comment
There was a problem hiding this comment.
Nice work debugging this! Tested locally, code LGTM.
|
@kertal Could you add |
💚 Build Succeeded |
of course, done |
|
@cjcenizal what do you think about fixing duplicate data on conversion? I think rollup support is still experimental, if yes, I don't think it's necessary to fix the data |
|
@kertal What's the alternative for fixing a rollup index pattern that's broken due to this bug? Recreating the index pattern and reassociating it with the dependent saved searches, visualizations, and dashboards? I could be wrong but this seems like a lot of work for the user. If so, then personally I think we owe it to the user to create the conversion. This way we can definitively state in our release notes that this bug is fixed in a specific version, since users upgrading to that version will have their index patterns magically healed. |
|
I can recommend going to elastic meetups. there was no bug visible in the presentation of @xeraa tonight at Vienna's elastic meetup. He was using 7.1. Going back a little in the history of this bug, I found out, that it was part of a #28762, which will be part of 7.2. there's no conversion necessary, since the bug didn't make it into production, and we won't let him escape |
|
🎉 Awesome! |
Rollup fields were were merged twice with other fields, this caused duplicates. Fix of a bug introduced by elastic#28762
Rollup fields were were merged twice with other fields, this caused duplicates. Fix of a bug introduced by elastic#28762
Rollup fields were were merged twice with other fields, this caused duplicates. Fix of a bug introduced by elastic#28762
Summary
Fixes #36297 introduced by #28762. It caused the fields of rollup based index patterns to be duplicated. After the merge of rollup field data with index field data, the rollup field data was appended a second time.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately