[feat] add reach-like functionality to object#37118
Merged
toddself merged 5 commits intoelastic:masterfrom May 24, 2019
Merged
Conversation
In elastic#36804 we need to validate a `Partial<HttpConfig>` object which may or may not have all the required keys attached to it. This is the type of use-case for `Joi.reach`, so we should expose a reach-like method on the object validation class so that you can return the validator for a specific key on an object.
Contributor
|
Pinging @elastic/kibana-platform |
spalger
reviewed
May 24, 2019
Contributor
💔 Build Failed |
7 tasks
Contributor
💚 Build Succeeded |
spalger
reviewed
May 24, 2019
spalger
reviewed
May 24, 2019
Contributor
💚 Build Succeeded |
toddself
added a commit
to toddself/kibana
that referenced
this pull request
May 24, 2019
* [feat] add reach-like functionality to object In elastic#36804 we need to validate a `Partial<HttpConfig>` object which may or may not have all the required keys attached to it. This is the type of use-case for `Joi.reach`, so we should expose a reach-like method on the object validation class so that you can return the validator for a specific key on an object. * [fix] change to validateKey * [fix] use throw error matcher * [fix] use same interface for validate * [fix] change test name]
toddself
added a commit
that referenced
this pull request
May 28, 2019
* [feat] add reach-like functionality to object In #36804 we need to validate a `Partial<HttpConfig>` object which may or may not have all the required keys attached to it. This is the type of use-case for `Joi.reach`, so we should expose a reach-like method on the object validation class so that you can return the validator for a specific key on an object. * [fix] change to validateKey * [fix] use throw error matcher * [fix] use same interface for validate * [fix] change test name]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #36804 we need to validate a
Partial<HttpConfig>object which mayor may not have all the required keys attached to it. This is the type
of use-case for
Joi.reach, so we should expose a reach-like method onthe object validation class so that you can return the validator for a
specific key on an object.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This includes a feature addition or change that requires a release note and was labeled appropriately