Issue 27786: Fixed default message if invalid value#36737
Merged
igoristic merged 2 commits intoelastic:masterfrom May 23, 2019
Merged
Issue 27786: Fixed default message if invalid value#36737igoristic merged 2 commits intoelastic:masterfrom
igoristic merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/stack-monitoring |
Contributor
💚 Build Succeeded |
chrisronline
approved these changes
May 22, 2019
Contributor
chrisronline
left a comment
There was a problem hiding this comment.
Tested and looks great! LGTM!
igoristic
added a commit
to igoristic/kibana
that referenced
this pull request
May 23, 2019
igoristic
added a commit
to igoristic/kibana
that referenced
this pull request
May 23, 2019
Contributor
Author
Contributor
|
@igoristic I see that this PR was merged ~6 hours ago. At that time, version 7.1.0 of Kibana had already been released. So we should remove the 7.1.0 label from this PR. Otherwise it will be confusing to users who try to figure out which releases this fix went into. |
igoristic
added a commit
that referenced
this pull request
May 23, 2019
This was referenced Jun 18, 2019
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Jun 18, 2019
chrisronline
added a commit
that referenced
this pull request
Jul 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #27786
The problem was the value was either of type Component (if invalid), or of type string|number which was then explicitly type-casted to a string.
Checklist