Remove browser basePath service, move functionality into browser http service#36611
Merged
eliperelman merged 5 commits intoelastic:masterfrom May 22, 2019
Merged
Remove browser basePath service, move functionality into browser http service#36611eliperelman merged 5 commits intoelastic:masterfrom
eliperelman merged 5 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-platform |
bf2f7a9 to
ffe8c34
Compare
joshdover
previously requested changes
May 17, 2019
Contributor
joshdover
left a comment
There was a problem hiding this comment.
Some structural comments before digging into some of the details
ffe8c34 to
a312ea2
Compare
Contributor
Author
|
@joshdover made changes from your review in a312ea2. |
mshustov
reviewed
May 17, 2019
src/core/public/application/capabilities/capabilities_service.tsx
Outdated
Show resolved
Hide resolved
src/core/public/application/capabilities/capabilities_service.tsx
Outdated
Show resolved
Hide resolved
src/core/public/application/capabilities/capabilities_service.test.ts
Outdated
Show resolved
Hide resolved
Haven't re-reviewed yet, but it looks like @restrry has spotted some things I noticed too
a312ea2 to
913b744
Compare
Contributor
Author
|
Current commits needing review have been updated in the description. |
d45afbd to
8f036b5
Compare
Contributor
💚 Build Succeeded |
cb11b0d to
7244e40
Compare
7244e40 to
41f8003
Compare
41f8003 to
92e07f9
Compare
92e07f9 to
5d054f7
Compare
joshdover
reviewed
May 22, 2019
joshdover
approved these changes
May 22, 2019
Contributor
joshdover
left a comment
There was a problem hiding this comment.
Looks good overall, have some thoughts on naming, but I'll leave that to you to decide.
b4e736b to
26f97bf
Compare
Contributor
💔 Build Failed |
joshdover
approved these changes
May 22, 2019
Contributor
💔 Build Failed |
… to removeBasePath
Contributor
💚 Build Succeeded |
26f97bf to
c4dab47
Compare
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
7 tasks
eliperelman
added a commit
to eliperelman/kibana
that referenced
this pull request
May 31, 2019
… service (elastic#36611) * Remove browser basePath service, move functionality into browser http service * Update generated documentation for removal of browser basePath * Fix type interface for removal of basePath * Split IHttpService into separate setup and start interfaces * Rename appendToBasePath to prependBasePath, rename removeFromBasePath to removeBasePath
eliperelman
added a commit
that referenced
this pull request
May 31, 2019
…r http service (#36611) (#37387) * Remove browser basePath service, move functionality into browser http service (#36611) * Remove browser basePath service, move functionality into browser http service * Update generated documentation for removal of browser basePath * Fix type interface for removal of basePath * Split IHttpService into separate setup and start interfaces * Rename appendToBasePath to prependBasePath, rename removeFromBasePath to removeBasePath * Fix import of http test setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The browser
basePathservice is a pretty small service which only has functionality for the manipulation of Kibana'sbasePathin order to affect HTTP requests. This patch removes the browserbasePathservice in favor of handling by the browser HTTP service.Commits needing review
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklistFor maintainers
Dev Docs
The browser
basePathservice is removed in favor of handling by the browserhttpservice. As thebasePathwas used for controlling the route used to make fetch requests, it makes sense to colocate this functionality into the HTTP service.