Remove required ConfigClass#36609
Merged
mshustov merged 9 commits intoelastic:masterfrom May 21, 2019
Merged
Conversation
Contributor
💔 Build Failed |
b9345c6 to
d811ff1
Compare
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
|
Pinging @elastic/kibana-platform |
rudolf
approved these changes
May 20, 2019
Contributor
rudolf
left a comment
There was a problem hiding this comment.
👍 This makes the API much simpler.
Contributor
💚 Build Succeeded |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
May 21, 2019
* remove LoggingConfig class * get rid of ElasticsearchConfig class * get rid of PluginsConfig class * get rid of HttpConfig Class * update ConfigService * update LegacyService * update testbed plugin * update docs
mshustov
added a commit
that referenced
this pull request
May 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close #36099
This PR makes ConfigClass declaration optional. End users can wrap Config in ConfigClass manually if it is beneficial. All core service do this in the constructors.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers