Update ui/vis imports to point to plugins/visualizations.#35764
Closed
lukeelmers wants to merge 9 commits intoelastic:masterfrom
Closed
Update ui/vis imports to point to plugins/visualizations.#35764lukeelmers wants to merge 9 commits intoelastic:masterfrom
lukeelmers wants to merge 9 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build Succeeded |
This was referenced Jun 10, 2019
Contributor
Author
|
Closing as our conventions for handling shimmed imports have changed since this exploration was started, and also because we will first try to move the code and re-export from This work will gradually be replaced in subsequent PRs, beginning with #43730 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge yet.
Reviewers
This is a follow up to #35625 & should be reviewed after that PR is merged.
In #35625, the
visualizationsplugin was introduced, with services forvisTypesandvisFiltersthat re-exported from theui/vismodule.In this PR, we are taking every import that references the
ui/visservices that were moved, and updating it to import fromplugins/visualizationsinstead ofui/vis. This will make it simpler for us to move theui/vismodule behind the scenes, and will also allow some time for 3rd party vis developers to update their plugin imports.Prior to merging, I'll update the dev docs issue with notes on these changes.
QA
This introduces no functional changes.
Dev Docs
This requires a dev docs entry, but rather than adding the notes here, I am combining them with the existing dev docs issue.