[i18n] extract untracked translations and prettier logging#35171
Merged
[i18n] extract untracked translations and prettier logging#35171
Conversation
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
|
Pinging @elastic/kibana-platform |
azasypkin
reviewed
Apr 29, 2019
Contributor
azasypkin
left a comment
There was a problem hiding this comment.
Code-wise approach looks good to me, but I defer to Platform team to review and test it thoroughly. Two main issues:
-
I couldn't force
i18n_checktool to actually complain about untracked translations (I tried to put i18n calls to packages/kbn-es andxpack/plugins/oss_telemetry, but tool didn't complain). Did I do something wrong? -
Label extraction seems to be broken - script silently exists and doesn't generate anything
Co-Authored-By: Bamieh <ahmadbamieh@gmail.com>
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
|
Pinging @elastic/kibana-stack-services |
stacey-gammon
approved these changes
Jun 14, 2019
stacey-gammon
left a comment
There was a problem hiding this comment.
some small suggestions, otherwise the embeddable changes LGTM, thanks!!
...lugins/embeddable_api/public/panel/panel_header/panel_actions/add_panel/add_panel_action.tsx
Outdated
Show resolved
Hide resolved
...lugins/embeddable_api/public/panel/panel_header/panel_actions/add_panel/add_panel_flyout.tsx
Outdated
Show resolved
Hide resolved
…er/panel_actions/add_panel/add_panel_flyout.tsx Co-Authored-By: Stacey Gammon <gammon@elastic.co>
…er/panel_actions/add_panel/add_panel_action.tsx Co-Authored-By: Stacey Gammon <gammon@elastic.co>
…o i18n/untracked_checks
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
mistic
approved these changes
Jun 17, 2019
Contributor
mistic
left a comment
There was a problem hiding this comment.
LGTM in the operations perspective
mikecote
approved these changes
Jun 17, 2019
Contributor
mikecote
left a comment
There was a problem hiding this comment.
LGTM, this caught issues in my upcoming PR 👍
Bamieh
added a commit
to Bamieh/kibana
that referenced
this pull request
Jun 17, 2019
…5171) * extract untracked translations and prettier logging * self code review * Update src/dev/run_i18n_check.ts Co-Authored-By: Bamieh <ahmadbamieh@gmail.com> * updating listR * run new i18n_check and fix errors * kbnEmbeddables -> embeddableApi * remove any type * Update src/legacy/core_plugins/embeddable_api/public/panel/panel_header/panel_actions/add_panel/add_panel_flyout.tsx Co-Authored-By: Stacey Gammon <gammon@elastic.co> * Update src/legacy/core_plugins/embeddable_api/public/panel/panel_header/panel_actions/add_panel/add_panel_action.tsx Co-Authored-By: Stacey Gammon <gammon@elastic.co> * self code review fixes * fix extract and integrate scripts * ts-ignore js file
Bamieh
added a commit
that referenced
this pull request
Jun 18, 2019
) (#39130) * [i18n] extract untracked translations and prettier logging (#35171) * extract untracked translations and prettier logging * self code review * Update src/dev/run_i18n_check.ts Co-Authored-By: Bamieh <ahmadbamieh@gmail.com> * updating listR * run new i18n_check and fix errors * kbnEmbeddables -> embeddableApi * remove any type * Update src/legacy/core_plugins/embeddable_api/public/panel/panel_header/panel_actions/add_panel/add_panel_flyout.tsx Co-Authored-By: Stacey Gammon <gammon@elastic.co> * Update src/legacy/core_plugins/embeddable_api/public/panel/panel_header/panel_actions/add_panel/add_panel_action.tsx Co-Authored-By: Stacey Gammon <gammon@elastic.co> * self code review fixes * fix extract and integrate scripts * ts-ignore js file * run i18n_check
This was referenced Jun 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
node scripts/i18n_check.jsnow searches for labels in untracked files and throws an error if it finds any.Running this script detected 2 plugins using
i18nbut not adding their namespace to the.i18nrc.jsonfile. This is problematic because we do not extract/translate those untracked packages.This PR also fixes those issues as well:
"embeddableApi": "src/legacy/core_plugins/embeddable_api"."xpack.code": "x-pack/plugins/code"Better Error logging: https://terminalizer.com/view/98ad16001206
Context: #27376
Dev Docs
Running
node scripts/i18n_check.jsnow searches for labels in untracked files and throws an error if it finds any.The i18n check tool now has an enhanced reporting experience with better error logging: