Fix babel initialization for graphql type generation#33962
Merged
weltenwort merged 2 commits intoelastic:masterfrom Mar 27, 2019
Merged
Fix babel initialization for graphql type generation#33962weltenwort merged 2 commits intoelastic:masterfrom
weltenwort merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/uptime |
skh
approved these changes
Mar 27, 2019
Contributor
skh
left a comment
There was a problem hiding this comment.
This fixes the problem for me in x-pack/plugin/infra. Thank you! 👍
Contributor
💔 Build Failed |
justinkambic
approved these changes
Mar 27, 2019
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
Likewise for Uptime.
LGTM - thanks!!
Contributor
|
jenkins test this |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Mar 27, 2019
This restores the functionality of the graphql type generation scripts after elastic#33093. In particular, it properly sets up the babel import hook so schemata can once more be imported from `.ts/.tsx` files.
joelgriffith
pushed a commit
that referenced
this pull request
Mar 27, 2019
This restores the functionality of the graphql type generation scripts after #33093. In particular, it properly sets up the babel import hook so schemata can once more be imported from `.ts/.tsx` files.
weltenwort
added a commit
that referenced
this pull request
Mar 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This restores the functionality of the graphql type generation scripts after #33093. In particular, it properly sets up the babel import hook so schemata can once more be imported from
.ts/.tsxfiles.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately