Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
756524a to
bec23fc
Compare
Contributor
💚 Build Succeeded |
Bargs
approved these changes
Mar 20, 2019
Contributor
Bargs
left a comment
There was a problem hiding this comment.
Code and functionality looks good. Inspector and vis are working now, which as far as I can remember were the two last hurdles when I left off. Tested with an old interval based pattern to ensure it still worked and it did. LGTM!
Thanks for taking this across the finish line @lukasolson
bec23fc to
60b16bc
Compare
Contributor
💚 Build Succeeded |
60b16bc to
0b9d909
Compare
Contributor
💚 Build Succeeded |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Mar 27, 2019
* Remove segmented fetch * Fix namespace * Remove unused translations
Contributor
Author
|
7.x (7.1.0): 002fc5e |
joelgriffith
pushed a commit
that referenced
this pull request
Mar 27, 2019
* Remove segmented fetch * Fix namespace * Remove unused translations
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #16324.
From the original PR: