[Maps] layer specific filtering by nreese · Pull Request #33209 · elastic/kibana

nreese · 2019-03-13T22:38:04Z

This PR adds ability to add filter to layer

…ters

elasticmachine · 2019-03-13T22:38:23Z

Pinging @elastic/kibana-gis

nreese · 2019-03-13T22:42:13Z

I had to deviate from the design a little bit. The QueryBar requires a submit button so I could not put the button in the footer.

Also, talked to @thomasneirynck, and we decided to skip showing a table of results because it did not make sense for Grid sources since Grid sources do not show individual documents.

elasticmachine · 2019-03-13T23:00:18Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-14T18:39:41Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-14T18:55:13Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-14T19:46:07Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-25T15:18:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

thomasneirynck · 2019-03-25T15:23:52Z

I prefer the pop-over as opposed to the modal. It looks clean, and users can continue see the data in the background, so it preserves some context.

elasticmachine · 2019-03-25T16:07:43Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-25T18:02:31Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

thomasneirynck

lgtm, but some minor suggestions.

thomasneirynck · 2019-03-25T18:30:58Z

src/legacy/ui/public/query_bar/components/query_bar.tsx

  private renderUpdateButton() {
-    const button = (
+    const button = this.props.customSubmitButton ? (
+      React.cloneElement(this.props.customSubmitButton, { onClick: this.onClickSubmitButton })


Why do we need the React.cloneElement?

That allows for the adding the onClick property while preserving all of the other props passed in with the button

thomasneirynck · 2019-03-25T18:31:53Z

src/legacy/ui/public/query_bar/components/query_bar.tsx

  refreshInterval?: number;
  showAutoRefreshOnly?: boolean;
  onRefreshChange?: (options: { isPaused: boolean; refreshInterval: number }) => void;
+  customSubmitButton?: any;


consider PropTypes.element

Typescript does recognize PropTypes. I had React.ReactNode but then there were TS lint errors

didn't know this, thanks

src/legacy/ui/public/query_bar/components/query_bar.tsx

x-pack/plugins/maps/public/components/layer_panel/filter_editor/_filter_editor.scss

thomasneirynck · 2019-03-25T18:40:28Z

x-pack/plugins/maps/public/components/layer_panel/filter_editor/filter_editor.js

+
+  _renderOpenButton() {
+    const query = this.props.layer.getQuery();
+    const openButtonLabel = query && query.query


would it make sense to not have this "Edit filter" button, and just have the previwer, that's either empty or has the preview of the string. I kind of like how the join-editor is editable like that. just click the preview, no need for extra button.

cc @cchaos What do you think?

x-pack/plugins/maps/public/shared/layers/heatmap_layer.js

x-pack/plugins/maps/public/shared/layers/sources/es_source.js

thomasneirynck · 2019-03-25T19:07:13Z

x-pack/plugins/maps/public/shared/layers/sources/es_source.js

    return  [this._descriptor.indexPatternId];
  }

+  supportsElasticsearchFilters() {


I'd make this a static function or static property on Source, and not a method on the prototype. The return true/false is independent of instance-state, but only depends on the type instead.

If the method is a static method then it has to be called on the Class instead of the instance. The method is executed from within a layer instance where I have easy access to the source instance, but not the source Class. It would be cumbersome to get the Class of the source instance and then call the static method on the class.

this._source.constructor.supportsElasticsearchFilters

but yeah, that looks somewhat funny. your call.

I will just leave it on prototype since that is consistent with isFieldAware, isRefreshTimerAware, and others

elasticmachine · 2019-03-25T19:13:48Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…icker

elasticmachine · 2019-03-25T20:57:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

thomasneirynck

Thanks, really cool

elasticmachine · 2019-03-26T16:53:42Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* render filters section in layer details * add popover with QueryBar * show index pattern type ahead * scss * add custom button to QueryBar * add setQuery action creator * wire together layer query to search source * remove old comment * update heatmap layer to consider layerQuery during resync logic * update getBounds to apply layer query * fix QueryBar typescript problems * add functional test for layer query * more typescript nonsense * fix jest test * use EuiPopover instead of EuiModal * close popover on button click * fix functional test with popover change * add empty state help text and use small padding on EuiCodeBlock * query_bar renderUpdateButton return early if not this.props.showDatePicker

* [Maps] layer specific filtering (#33209) * render filters section in layer details * add popover with QueryBar * show index pattern type ahead * scss * add custom button to QueryBar * add setQuery action creator * wire together layer query to search source * remove old comment * update heatmap layer to consider layerQuery during resync logic * update getBounds to apply layer query * fix QueryBar typescript problems * add functional test for layer query * more typescript nonsense * fix jest test * use EuiPopover instead of EuiModal * close popover on button click * fix functional test with popover change * add empty state help text and use small padding on EuiCodeBlock * query_bar renderUpdateButton return early if not this.props.showDatePicker * skip fitToBounds tests until fix is merged

nreese added 9 commits March 11, 2019 16:33

render filters section in layer details

e643c19

Merge branch 'master' of github.com:elastic/kibana into map_layer_fil…

f08955b

…ters

add popover with QueryBar

ffac984

Merge branch 'master' of github.com:elastic/kibana into map_layer_fil…

514f994

…ters

show index pattern type ahead

494d777

scss

18b24f8

add custom button to QueryBar

1935edc

add setQuery action creator

bf48128

wire together layer query to search source

001634a

nreese requested a review from a team as a code owner March 13, 2019 22:38

nreese added Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result v8.0.0 v7.2.0 labels Mar 13, 2019

remove old comment

715f154

nreese added release_note:enhancement and removed enhancement New value added to drive a business result labels Mar 14, 2019

nreese added 2 commits March 14, 2019 12:09

update heatmap layer to consider layerQuery during resync logic

c1125e3

update getBounds to apply layer query

6d67284

fix QueryBar typescript problems

f3eca88

add functional test for layer query

f864425

nreese added the review label Mar 14, 2019

nreese requested review from cchaos and thomasneirynck March 14, 2019 19:35

thomasneirynck closed this Mar 25, 2019

thomasneirynck reopened this Mar 25, 2019

nreese mentioned this pull request Mar 25, 2019

[Maps] split settings into layer and source panels #33788

Merged

fix functional test with popover change

8319302

add empty state help text and use small padding on EuiCodeBlock

6f7210a

thomasneirynck reviewed Mar 25, 2019

View reviewed changes

query_bar renderUpdateButton return early if not this.props.showDateP…

7e6963f

…icker

thomasneirynck requested review from cchaos and thomasneirynck March 26, 2019 03:36

thomasneirynck approved these changes Mar 26, 2019

View reviewed changes

nreese mentioned this pull request Mar 26, 2019

[Maps] Add clone layer to layer actions #33853

Merged

merge with master

33c3a8e

nreese merged commit 465d37b into elastic:master Mar 27, 2019

nreese mentioned this pull request Mar 27, 2019

[7.x] [Maps] layer specific filtering (#33209) #33954

Closed

nreese mentioned this pull request Mar 28, 2019

[7.x] [Maps] layer specific filtering (#33209) #34088

Closed

nreese mentioned this pull request Mar 28, 2019

[7.x] [Maps] layer specific filtering (#33209) #34090

Merged

nreese mentioned this pull request Jun 21, 2019

[Maps] Setting time range and query for layer UI #30637

Closed

nreese mentioned this pull request Feb 24, 2020

Coordinate Map - Support filter aggregations #14541

Closed

Conversation

nreese commented Mar 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Mar 13, 2019

Uh oh!

nreese commented Mar 13, 2019

Uh oh!

elasticmachine commented Mar 13, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Mar 14, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Mar 14, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Mar 14, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Mar 25, 2019

💔 Build Failed

Uh oh!

thomasneirynck commented Mar 25, 2019

Uh oh!

elasticmachine commented Mar 25, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Mar 25, 2019

💚 Build Succeeded

Uh oh!

thomasneirynck left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nreese Mar 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Mar 25, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Mar 25, 2019

💚 Build Succeeded

Uh oh!

thomasneirynck left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Mar 26, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

nreese commented Mar 13, 2019 •

edited

Loading

nreese Mar 25, 2019 •

edited

Loading