Skip to content

Add create_snapshot privilege#31086

Merged
albertzaharovits merged 4 commits intomasterfrom
albertzaharovits-add-create-snapshot-privilege
Feb 20, 2019
Merged

Add create_snapshot privilege#31086
albertzaharovits merged 4 commits intomasterfrom
albertzaharovits-add-create-snapshot-privilege

Conversation

@albertzaharovits
Copy link
Copy Markdown
Contributor

@albertzaharovits albertzaharovits commented Feb 14, 2019

A new cluster privilege type has been added to ES in elastic/elasticsearch#35820 .

@albertzaharovits
Add create_snapshot privilege
6dbbe50 
A new cluster privilege type has been added to ES in elastic/elasticsearch#35820 .
@albertzaharovits albertzaharovits added the Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// label Feb 14, 2019
@albertzaharovits albertzaharovits self-assigned this Feb 14, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 14, 2019

Pinging @elastic/kibana-security

@albertzaharovits albertzaharovits requested a review from a team as a code owner February 14, 2019 10:34
@albertzaharovits albertzaharovits mentioned this pull request Feb 14, 2019
Merged
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 14, 2019

💔 Build Failed

legrego
legrego reviewed Feb 14, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We unfortunately have a bit of duplication that we haven't addressed yet. Can you also add this to shield_privileges?

CI is failing because of an outdated snapshot as a result of the new privilege.
You can update the snapshot by running node scripts/jest ./plugins/security/public -u from the x-pack directory.

@albertzaharovits
Copy link
Copy Markdown
Contributor Author

albertzaharovits commented Feb 19, 2019

Hey @legrego , thanks for the pointers!

I have updated the PR, can you take another look please?

Also, elastic/elasticsearch#35820 added a reserved role (snapshot_user) as well. Does kibana store those as well? I think not.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 19, 2019

💔 Build Failed

@legrego legrego requested a review from kobelb February 19, 2019 12:44
@kobelb
Copy link
Copy Markdown
Contributor

kobelb commented Feb 19, 2019

This PR will need to have master merged into it to get CI to go green.

Also, elastic/elasticsearch#35820 added a reserved role (snapshot_user) as well. Does kibana store those as well? I think not.

It does not, we use the ES APIs to get these roles.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 19, 2019

💚 Build Succeeded

kobelb
kobelb approved these changes Feb 19, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Albert!

@albertzaharovits albertzaharovits merged commit 2c30e9f into master Feb 20, 2019
@albertzaharovits albertzaharovits deleted the albertzaharovits-add-create-snapshot-privilege branch February 20, 2019 12:47
albertzaharovits added a commit to albertzaharovits/kibana that referenced this pull request Feb 20, 2019
@albertzaharovits
Add create_snapshot privilege (elastic#31086)
04f5a77 
A new cluster privilege type has been added to ES in [elastic/elasticsearch#35820](elastic/elasticsearch#35820) .
@albertzaharovits
Copy link
Copy Markdown
Contributor Author

albertzaharovits commented Feb 20, 2019

Thanks for the shepherding Larry and Brandon!
@kobelb I am backporting this to 7.x . Should I backport to 7.0 and 6.7 as well, given that the compatible code in ES exists since 6.7 ?

@kobelb
Copy link
Copy Markdown
Contributor

kobelb commented Feb 20, 2019

Sure, backporting to 7.0/6.7 seems fine in this situation. If you'd like, I can do so and let CI run, sometimes the Jest snapshots between branches/versions can be finnicky.

@albertzaharovits
Copy link
Copy Markdown
Contributor Author

albertzaharovits commented Feb 20, 2019

I'll take your kind offer to backport! #31573 is stuck 😞 ...

@kobelb kobelb mentioned this pull request Feb 20, 2019
Merged
kobelb pushed a commit to kobelb/kibana that referenced this pull request Feb 20, 2019
@albertzaharovits @kobelb
Add create_snapshot privilege (elastic#31086)
e87c0bc 
A new cluster privilege type has been added to ES in [elastic/elasticsearch#35820](elastic/elasticsearch#35820) .
@kobelb kobelb mentioned this pull request Feb 20, 2019
Merged
kobelb pushed a commit to kobelb/kibana that referenced this pull request Feb 20, 2019
@albertzaharovits @kobelb
Add create_snapshot privilege (elastic#31086)
814ae06 
A new cluster privilege type has been added to ES in [elastic/elasticsearch#35820](elastic/elasticsearch#35820) .
@kobelb kobelb mentioned this pull request Feb 20, 2019
Merged
kobelb pushed a commit to kobelb/kibana that referenced this pull request Feb 20, 2019
@albertzaharovits @kobelb
Add create_snapshot privilege (elastic#31086)
6fd5b86 
A new cluster privilege type has been added to ES in [elastic/elasticsearch#35820](elastic/elasticsearch#35820) .
kobelb added a commit that referenced this pull request Feb 20, 2019
@kobelb
Add create_snapshot privilege (#31086) (#31598)
fd58b08 
A new cluster privilege type has been added to ES in [elastic/elasticsearch#35820](elastic/elasticsearch#35820) .
kobelb added a commit that referenced this pull request Feb 20, 2019
@kobelb
Add create_snapshot privilege (#31086) (#31596)
f4746f2 
A new cluster privilege type has been added to ES in [elastic/elasticsearch#35820](elastic/elasticsearch#35820) .
kobelb added a commit that referenced this pull request Feb 20, 2019
@kobelb
Add create_snapshot privilege (#31086) (#31597)
bcc85e4 
A new cluster privilege type has been added to ES in [elastic/elasticsearch#35820](elastic/elasticsearch#35820) .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legrego legrego legrego left review comments

@kobelb kobelb kobelb approved these changes

Assignees

@albertzaharovits albertzaharovits

Labels

Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v6.7.0 v7.0.0 v7.2.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@albertzaharovits @elasticmachine @kobelb @legrego