[Uptime] Add API functional tests for uptime graphQL by justinkambic · Pull Request #29128 · elastic/kibana

I don't see the test results in the Jenkins job, but maybe I'm looking in the wrong place.
I think you need to add tests to test/api_integration/apis/index.js

LeeDr · 2019-01-24T19:15:43Z

x-pack/test/api_integration/apis/uptime/graphql/doc_count.js

+    const supertest = getService('supertest');
+    const esArchiver = getService('esArchiver');
+    const archive = 'uptime/full_heartbeat';
+    before('load heartbeat data', () => esArchiver.load(archive));


If all the tests in the index.js are loading the same data (it looks like they're all loading uptime/full_heartbeat) you could just put the before and after in the index.js file so it loads the data once before the first test and unloads it after the last test.

++ - addressed in 6a3cb40.

justinkambic · 2019-01-24T22:45:21Z

I don't see the test results in the Jenkins job, but maybe I'm looking in the wrong place.
I think you need to add tests to test/api_integration/apis/index.js

We do have the uptime directory imported in that file, and the index of our directory imports both GQL and REST API tests. I'll let you know if I don't see it on the latest CI run.

justinkambic · 2019-01-24T23:14:23Z

jenkins test this

elasticmachine · 2019-01-24T23:19:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-24T23:56:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

justinkambic · 2019-01-25T04:01:00Z

@LeeDr you can see the tests run in the latest CI job here: https://kibana-ci.elastic.co/job/elastic+kibana+pull-request/8917/JOB=x-pack-ciGroup5,node=immutable/testReport/X-Pack%20API%20Integration%20Tests/

LeeDr · 2019-01-25T16:53:19Z

LGTM

elasticmachine · 2019-01-25T21:08:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Add API functional tests for uptime graphQL. * Remove obsolete code. * Add CI group for UI functional tests. * Delete obsolete code, rename heartbeat es archive. * Refactor adapter methods. * Refactor adapter methods. * Attempt to fix ci-group tag error. * Skip functional app tests until later PR. * Remove unused code. * Optimize test runs. * Add uptime to api test index. * Fix formatting.

* Refactor es queries and associated components/endpoints. * Add unit tests, repair broken tests. * [Uptime] Add API functional tests for uptime graphQL (#29128) * Add API functional tests for uptime graphQL. * Remove obsolete code. * Add CI group for UI functional tests. * Delete obsolete code, rename heartbeat es archive. * Refactor adapter methods. * Refactor adapter methods. * Attempt to fix ci-group tag error. * Skip functional app tests until later PR. * Remove unused code. * Optimize test runs. * Add uptime to api test index. * Fix formatting. * Add HB 7.0 data for API tests. * Configure first error_list test to work with 7.x data. * Configure error_list filtered by id to work with 7.x data. * Configure error_list functional tests to work with 7.x data. * Update snapshot test to work with 7.x data. * Update snapshot down filtered test to work with 7.x data. * Configure snapshot up test to work with 7.x data. * Configure ping list tests to work with 7.x data. * Configure monitor list tests to work with 7.x data. * Configure monitor status bar tests to work with 7.x data. * Configure filterBar tests to work with 7.x data. * Configure docCount tests to work with 7.x data. * Simplify code based on PR feedback. * Add loading spinner to monitor page title based on PR feedback. * Rename GQL type based on PR feedback. * Remove use of 'undefined' in ES query based on PR feedback. * Simplify code based on PR feedback. * Add definite size/shard_size for terms agg based on PR feedback. * Simplify ES query based on PR feedback. * Update x-pack/plugins/uptime/server/lib/adapters/monitors/elasticsearch_monitors_adapter.ts Implement PR feedback. Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Increase size for ES errors query based on PR feedback. * Fix hardcoded field in terms filter based on PR feedback. * Simplify get code for monitors function. * Reduce unnecessarily large size for terms agg based on PR feedback. * Pluralize filter bar props. * Refactor filter bar query based on PR feedback. * Update test. * Fix busted GQL query. * Update functional test docs to use data without buggy values. * Update index name in HB functional api test docs. * Update snapshot base functional test. * Make snapshot filter tests pass, fix associated bug. * Configure remaining snapshot e2e tests to work with 7.x data. * Give better variable names and comments for ugly code. * Configure ping list query tests to work with updated 7.x data. * Rename graphql describe block. * Update monitor status bar query tests to work with updated 7.x data. * Update monitor list query tests to work with updated 7.x data. * Update filter bar query to work with updated 7.x data. * Update error list query to work with updated 7.x data. * Update doc count fixture to work with new 7.x data. * Address PR feedback with filter typing to clean up code. * Add comments based on PR feedback. * Fix bug introduced in 8856be8.

* Refactor es queries and associated components/endpoints. * Add unit tests, repair broken tests. * [Uptime] Add API functional tests for uptime graphQL (#29128) * Add API functional tests for uptime graphQL. * Remove obsolete code. * Add CI group for UI functional tests. * Delete obsolete code, rename heartbeat es archive. * Refactor adapter methods. * Refactor adapter methods. * Attempt to fix ci-group tag error. * Skip functional app tests until later PR. * Remove unused code. * Optimize test runs. * Add uptime to api test index. * Fix formatting. * Add HB 7.0 data for API tests. * Configure first error_list test to work with 7.x data. * Configure error_list filtered by id to work with 7.x data. * Configure error_list functional tests to work with 7.x data. * Update snapshot test to work with 7.x data. * Update snapshot down filtered test to work with 7.x data. * Configure snapshot up test to work with 7.x data. * Configure ping list tests to work with 7.x data. * Configure monitor list tests to work with 7.x data. * Configure monitor status bar tests to work with 7.x data. * Configure filterBar tests to work with 7.x data. * Configure docCount tests to work with 7.x data. * Simplify code based on PR feedback. * Add loading spinner to monitor page title based on PR feedback. * Rename GQL type based on PR feedback. * Remove use of 'undefined' in ES query based on PR feedback. * Simplify code based on PR feedback. * Add definite size/shard_size for terms agg based on PR feedback. * Simplify ES query based on PR feedback. * Update x-pack/plugins/uptime/server/lib/adapters/monitors/elasticsearch_monitors_adapter.ts Implement PR feedback. Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Increase size for ES errors query based on PR feedback. * Fix hardcoded field in terms filter based on PR feedback. * Simplify get code for monitors function. * Reduce unnecessarily large size for terms agg based on PR feedback. * Pluralize filter bar props. * Refactor filter bar query based on PR feedback. * Update test. * Fix busted GQL query. * Update functional test docs to use data without buggy values. * Update index name in HB functional api test docs. * Update snapshot base functional test. * Make snapshot filter tests pass, fix associated bug. * Configure remaining snapshot e2e tests to work with 7.x data. * Give better variable names and comments for ugly code. * Configure ping list query tests to work with updated 7.x data. * Rename graphql describe block. * Update monitor status bar query tests to work with updated 7.x data. * Update monitor list query tests to work with updated 7.x data. * Update filter bar query to work with updated 7.x data. * Update error list query to work with updated 7.x data. * Update doc count fixture to work with new 7.x data. * Create functional UI tests for Overview and Monitor pages. * Add additional waits to functional UI test to try to prevent flakiness. * [ftr/services/superDatePicker] make specialized service * Add data-test-subj value to monitor link. * Remove wait calls from UI tests. * Set default timezone for tests' kibana server. * Add @types for mocha and expect.js. * Implement PR feedback. * Remove added types. * Re-add mocha types. * Remove obsolete comment. * Disable timestamp on uptime app navigation for functional tests. * Undo previous change for default value of function parameter. * Add redirect hack to uptime client to change window location when expected router path is not satisfied.

* Refactor es queries and associated components/endpoints. * Add unit tests, repair broken tests. * [Uptime] Add API functional tests for uptime graphQL (elastic#29128) * Add API functional tests for uptime graphQL. * Remove obsolete code. * Add CI group for UI functional tests. * Delete obsolete code, rename heartbeat es archive. * Refactor adapter methods. * Refactor adapter methods. * Attempt to fix ci-group tag error. * Skip functional app tests until later PR. * Remove unused code. * Optimize test runs. * Add uptime to api test index. * Fix formatting. * Add HB 7.0 data for API tests. * Configure first error_list test to work with 7.x data. * Configure error_list filtered by id to work with 7.x data. * Configure error_list functional tests to work with 7.x data. * Update snapshot test to work with 7.x data. * Update snapshot down filtered test to work with 7.x data. * Configure snapshot up test to work with 7.x data. * Configure ping list tests to work with 7.x data. * Configure monitor list tests to work with 7.x data. * Configure monitor status bar tests to work with 7.x data. * Configure filterBar tests to work with 7.x data. * Configure docCount tests to work with 7.x data. * Simplify code based on PR feedback. * Add loading spinner to monitor page title based on PR feedback. * Rename GQL type based on PR feedback. * Remove use of 'undefined' in ES query based on PR feedback. * Simplify code based on PR feedback. * Add definite size/shard_size for terms agg based on PR feedback. * Simplify ES query based on PR feedback. * Update x-pack/plugins/uptime/server/lib/adapters/monitors/elasticsearch_monitors_adapter.ts Implement PR feedback. Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Increase size for ES errors query based on PR feedback. * Fix hardcoded field in terms filter based on PR feedback. * Simplify get code for monitors function. * Reduce unnecessarily large size for terms agg based on PR feedback. * Pluralize filter bar props. * Refactor filter bar query based on PR feedback. * Update test. * Fix busted GQL query. * Update functional test docs to use data without buggy values. * Update index name in HB functional api test docs. * Update snapshot base functional test. * Make snapshot filter tests pass, fix associated bug. * Configure remaining snapshot e2e tests to work with 7.x data. * Give better variable names and comments for ugly code. * Configure ping list query tests to work with updated 7.x data. * Rename graphql describe block. * Update monitor status bar query tests to work with updated 7.x data. * Update monitor list query tests to work with updated 7.x data. * Update filter bar query to work with updated 7.x data. * Update error list query to work with updated 7.x data. * Update doc count fixture to work with new 7.x data. * Create functional UI tests for Overview and Monitor pages. * Add additional waits to functional UI test to try to prevent flakiness. * [ftr/services/superDatePicker] make specialized service * Add data-test-subj value to monitor link. * Remove wait calls from UI tests. * Set default timezone for tests' kibana server. * Add @types for mocha and expect.js. * Implement PR feedback. * Remove added types. * Re-add mocha types. * Remove obsolete comment. * Disable timestamp on uptime app navigation for functional tests. * Undo previous change for default value of function parameter. * Add redirect hack to uptime client to change window location when expected router path is not satisfied.

* Refactor es queries and associated components/endpoints. * Add unit tests, repair broken tests. * [Uptime] Add API functional tests for uptime graphQL (#29128) * Add API functional tests for uptime graphQL. * Remove obsolete code. * Add CI group for UI functional tests. * Delete obsolete code, rename heartbeat es archive. * Refactor adapter methods. * Refactor adapter methods. * Attempt to fix ci-group tag error. * Skip functional app tests until later PR. * Remove unused code. * Optimize test runs. * Add uptime to api test index. * Fix formatting. * Add HB 7.0 data for API tests. * Configure first error_list test to work with 7.x data. * Configure error_list filtered by id to work with 7.x data. * Configure error_list functional tests to work with 7.x data. * Update snapshot test to work with 7.x data. * Update snapshot down filtered test to work with 7.x data. * Configure snapshot up test to work with 7.x data. * Configure ping list tests to work with 7.x data. * Configure monitor list tests to work with 7.x data. * Configure monitor status bar tests to work with 7.x data. * Configure filterBar tests to work with 7.x data. * Configure docCount tests to work with 7.x data. * Simplify code based on PR feedback. * Add loading spinner to monitor page title based on PR feedback. * Rename GQL type based on PR feedback. * Remove use of 'undefined' in ES query based on PR feedback. * Simplify code based on PR feedback. * Add definite size/shard_size for terms agg based on PR feedback. * Simplify ES query based on PR feedback. * Update x-pack/plugins/uptime/server/lib/adapters/monitors/elasticsearch_monitors_adapter.ts Implement PR feedback. Co-Authored-By: justinkambic <justin.kambic@elastic.co> * Increase size for ES errors query based on PR feedback. * Fix hardcoded field in terms filter based on PR feedback. * Simplify get code for monitors function. * Reduce unnecessarily large size for terms agg based on PR feedback. * Pluralize filter bar props. * Refactor filter bar query based on PR feedback. * Update test. * Fix busted GQL query. * Update functional test docs to use data without buggy values. * Update index name in HB functional api test docs. * Update snapshot base functional test. * Make snapshot filter tests pass, fix associated bug. * Configure remaining snapshot e2e tests to work with 7.x data. * Give better variable names and comments for ugly code. * Configure ping list query tests to work with updated 7.x data. * Rename graphql describe block. * Update monitor status bar query tests to work with updated 7.x data. * Update monitor list query tests to work with updated 7.x data. * Update filter bar query to work with updated 7.x data. * Update error list query to work with updated 7.x data. * Update doc count fixture to work with new 7.x data. * Create functional UI tests for Overview and Monitor pages. * Add additional waits to functional UI test to try to prevent flakiness. * [ftr/services/superDatePicker] make specialized service * Add data-test-subj value to monitor link. * Remove wait calls from UI tests. * Set default timezone for tests' kibana server. * Add @types for mocha and expect.js. * Implement PR feedback. * Remove added types. * Re-add mocha types. * Remove obsolete comment. * Disable timestamp on uptime app navigation for functional tests. * Undo previous change for default value of function parameter. * Add redirect hack to uptime client to change window location when expected router path is not satisfied.

Add API functional tests for uptime graphQL.

b99bb33

justinkambic added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v6.7.0 labels Jan 22, 2019

justinkambic assigned andrewvc Jan 22, 2019

justinkambic self-assigned this Jan 23, 2019

Merge branch '6.x' into uptime_functional-tests6.x

e4a314f

justinkambic added 2 commits January 23, 2019 10:21

Remove obsolete code.

8ecf0a9

Merge branch '6.x' into uptime_functional-tests6.x

508a220

Add CI group for UI functional tests.

67aaf9f

justinkambic added 3 commits January 23, 2019 13:15

Delete obsolete code, rename heartbeat es archive.

7b71ac9

Refactor adapter methods.

c19a35d

Refactor adapter methods.

d9211e3

Attempt to fix ci-group tag error.

598a4bf

justinkambic added the test label Jan 23, 2019

Skip functional app tests until later PR.

8e2f1ac

justinkambic added 2 commits January 23, 2019 17:44

Merge branch '6.x' into uptime_functional-tests6.x

af8d429

Remove unused code.

5a1e236

justinkambic requested review from andrewvc and bmcconaghy and removed request for bmcconaghy January 24, 2019 00:08

justinkambic requested a review from LeeDr January 24, 2019 00:09

andrewvc approved these changes Jan 24, 2019

View reviewed changes

LeeDr suggested changes Jan 24, 2019

View reviewed changes

justinkambic added 4 commits January 24, 2019 17:27

Merge branch '6.x' into uptime_functional-tests6.x

21cccec

Optimize test runs.

6a3cb40

Add uptime to api test index.

1d1116b

Fix formatting.

cc8e306

LeeDr approved these changes Jan 25, 2019

View reviewed changes

Merge branch '6.x' into uptime_functional-tests6.x

b2ef4bb

justinkambic merged commit 44e98ce into elastic:6.x Jan 25, 2019

justinkambic mentioned this pull request Jan 28, 2019

[Uptime] Port functional tests to 7.x #29398

Merged

Conversation

justinkambic commented Jan 22, 2019

Summary

Uh oh!

elasticmachine commented Jan 22, 2019

Uh oh!

elasticmachine commented Jan 22, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 23, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 23, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 23, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 23, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 23, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 23, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 23, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 23, 2019

💚 Build Succeeded

Uh oh!

andrewvc left a comment

Choose a reason for hiding this comment

Uh oh!

LeeDr left a comment

Choose a reason for hiding this comment

Uh oh!

LeeDr Jan 24, 2019

Choose a reason for hiding this comment

Uh oh!

justinkambic Jan 24, 2019

Choose a reason for hiding this comment

Uh oh!

justinkambic commented Jan 24, 2019

Uh oh!

justinkambic commented Jan 24, 2019

Uh oh!

elasticmachine commented Jan 24, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 24, 2019

💚 Build Succeeded

Uh oh!

justinkambic commented Jan 25, 2019

Uh oh!

LeeDr commented Jan 25, 2019

Uh oh!

elasticmachine commented Jan 25, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants