Make the date in warnings optional for Console#28995
Merged
jasontedor merged 1 commit intoelastic:masterfrom Jan 18, 2019
Merged
Make the date in warnings optional for Console#28995jasontedor merged 1 commit intoelastic:masterfrom
jasontedor merged 1 commit intoelastic:masterfrom
Conversation
Elasticsearch wants to move to remove the warning date from warning headers in deprecation messages that are serialized into response headers. This commit is a step towards enabling Elasticsearch to do that by making the warn date optional in the regular expression used for processing warning headers. This is consistent with RFC 7234 where the warn date can be optional. By making this optional here, Elasticsearch can then follow-up and remove the warn date without breaking Kibana. A follow-up in Kibana can then remove this component from the regular expression instead of leaving it behind as optional.
Contributor
|
Pinging @elastic/es-ui |
Contributor
💚 Build Succeeded |
bmcconaghy
approved these changes
Jan 18, 2019
Contributor
bmcconaghy
left a comment
There was a problem hiding this comment.
Code LGTM, thanks for doing this Jason.
jasontedor
added a commit
that referenced
this pull request
Jan 18, 2019
Elasticsearch wants to move to remove the warning date from warning headers in deprecation messages that are serialized into response headers. This commit is a step towards enabling Elasticsearch to do that by making the warn date optional in the regular expression used for processing warning headers. This is consistent with RFC 7234 where the warn date can be optional. By making this optional here, Elasticsearch can then follow-up and remove the warn date without breaking Kibana. A follow-up in Kibana can then remove this component from the regular expression instead of leaving it behind as optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elasticsearch wants to move to remove the warning date from warning headers in deprecation messages that are serialized into response headers. This commit is a step towards enabling Elasticsearch to do that by making the warn date optional in the regular expression used for processing warning headers. This is consistent with RFC 7234 where the warn date can be optional. By making this optional here, Elasticsearch can then follow-up and remove the warn date without breaking Kibana. A follow-up in Kibana can then remove this component from the regular expression instead of leaving it behind as optional.
Relates elastic/elasticsearch#37597