[Monitoring] Add flag to enable/disable CCR monitoring UI by chrisronline · Pull Request #28840 · elastic/kibana

chrisronline · 2019-01-16T15:10:43Z

Resolves https://github.com/elastic/stack-monitoring/issues/21

This PR simply adds a config xpack.monitoring.ui.ccr.enabled that, when set to false, will not show the CCR tab under the Elasticsearch area of the Monitoring UI.

elasticmachine · 2019-01-16T15:10:45Z

Pinging @elastic/stack-monitoring

ycombinator · 2019-01-16T15:18:22Z

I'm not sure we need another flag on the Kibana side here. Cloud is disabling CCR in ES already via the xpack.ccr.enabled flag. So I'd prefer if the Monitoring UI just did a GET _cluster/settings?include_defaults&filter_path=defaults.xpack.ccr.enabled and read the enabled/disabled value from there (it's okay to look directly under defaults for this setting as it's not dynamically update-able).

elasticmachine · 2019-01-16T15:49:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

chrisronline · 2019-01-16T16:05:38Z

@ycombinator Will do. I tried to mess with that setting in my elasticsearch.yml, but there are errors at startup that will be fixed by elastic/elasticsearch#37432

x-pack/plugins/monitoring/server/lib/elasticsearch/ccr.js

ycombinator · 2019-01-16T18:22:04Z

I have CCR enabled in ES (default settings, didn't change anything), and I see this weird behavior in the UI:

Specifically:

Notice the slight delay for the CCR tab to show up when the page loads initially. Not sure if there's something you can do about this but it's probably not a big deal if you can't.
The bigger issue: the CCR tab disappears after clicking on it. The cluster name disappears from the breadcrumbs too. If you click back to the Overview tab, the CCR tab appears again.

chrisronline · 2019-01-16T18:39:40Z

I think for 1 we have to either accept this delay (in the current code architecture, which is also related to #28245) in cloud or in the standalone kibana. If we accept the delay on cloud, the CCR link will appear for a brief second, then disappear. I think the current code and UX is the better of the two so I'm inclined to leave as is.

elasticmachine · 2019-01-16T18:40:33Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-16T19:18:57Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

chrisronline · 2019-01-16T19:57:10Z

@ycombinator Did some refactoring in 76add94 to correct the UX issue. Thanks for pointing that out!

ycombinator · 2019-01-16T20:16:56Z

The janky UX issues I found earlier have gone away now. 👍

However, I'm now running into elastic/elasticsearch#37432 when trying to test this PR with setting xpack.ccr.enabled: false in my elasticsearch.yml. Added the blocked label.

elasticmachine · 2019-01-16T20:54:24Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

chrisronline · 2019-01-16T21:48:47Z

x-pack/plugins/monitoring/server/lib/elasticsearch/ccr.js

+}
+
+export async function checkCcrEnabled(req) {
+  const { callWithRequest } = req.server.plugins.elasticsearch.getCluster('monitoring');


Is this the right cluster to check against? Or is it admin? @pickypg

Ah crap, of course! We can't just call this API against the production or monitoring clusters 🤦‍♂️. What we need is to know via monitoring data if CCR is enabled or disabled on a particular production cluster. I'm not sure we have the data on whether CCR is enabled or not in .monitoring-es-*.

We will automatically start collecting this information in cluster_stats documents under the stack_stats.xpack.ccr.* field once elastic/elasticsearch#37256 is merged. Until then we can update the code in this PR to look at this field to make the determination whether to show the CCR tab or not.

elasticmachine · 2019-01-16T22:03:59Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cachedout · 2019-01-17T23:22:15Z

x-pack/plugins/monitoring/public/directives/main/index.js

      config.watch('k7design', (val) => scope.showPluginBreadcrumbs = !val);

      function getSetupObj() {
+        console.log(attributes);


Did you mean to leave this in? :)

Not at all! Thanks!

elasticmachine · 2019-01-18T14:45:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

ycombinator · 2019-01-26T16:03:42Z

elasticmachine · 2019-01-28T17:00:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-28T20:05:33Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cachedout · 2019-01-30T15:41:36Z

@chrisronline This looks like it's ready to go for 6.7 :)

chrisronline · 2019-01-30T15:43:22Z

Unfortunately, not yet. I need to test the code changes I made in response to @ycombinator's comment: #28840 (comment). Should be ready soon

…bled_flag

elasticmachine · 2019-01-30T18:46:19Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…bled_flag

elasticmachine · 2019-02-04T18:53:36Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-02-04T20:10:05Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-02-04T21:11:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

chrisronline · 2019-02-05T02:18:19Z

Backport:
6.x: fbe7667

Add flag to enable/disable CCR monitoring UI

9322571

chrisronline added review v7.0.0 Team:Monitoring Stack Monitoring team v6.7.0 labels Jan 16, 2019

chrisronline self-assigned this Jan 16, 2019

chrisronline requested a review from ycombinator January 16, 2019 15:10

chrisronline added 2 commits January 16, 2019 12:45

Use the cluster setting instead of a new config

483d8dc

Remove debug

e3814e6

chrisronline commented Jan 16, 2019

View reviewed changes

x-pack/plugins/monitoring/server/lib/elasticsearch/ccr.js Outdated Show resolved Hide resolved

ycombinator reviewed Jan 16, 2019

View reviewed changes

x-pack/plugins/monitoring/server/lib/elasticsearch/ccr.js Show resolved Hide resolved

Update based on PR feedback

e1b6543

ycombinator reviewed Jan 16, 2019

View reviewed changes

x-pack/plugins/monitoring/server/lib/elasticsearch/ccr.js Outdated Show resolved Hide resolved

Ensure the CCR tab shows up on the CCR page

9ecd542

Rework this so we remove the janky UX

76add94

ycombinator added the blocked label Jan 16, 2019

chrisronline added 2 commits January 16, 2019 16:24

Update tests

93d781e

Handle both string and boolean

23d043d

chrisronline commented Jan 16, 2019

View reviewed changes

cachedout reviewed Jan 17, 2019

View reviewed changes

Remove debug

f1c196f

ycombinator mentioned this pull request Jan 22, 2019

Added ccr to xpack usage infrastructure elastic/elasticsearch#37256

Merged

Merge in master

2c30b0a

Fix tests

929ed87

cachedout approved these changes Jan 30, 2019

View reviewed changes

chrisronline added 2 commits January 30, 2019 10:48

Merge remote-tracking branch 'elastic/master' into monitoring/ccr_ena…

846ae70

…bled_flag

Refactor this to use the stack_stats part of the cluster_stats document

563b5fc

chrisronline added 2 commits February 4, 2019 09:05

Merge remote-tracking branch 'elastic/master' into monitoring/ccr_ena…

0fa1734

…bled_flag

Update the api integration tests

a1389c2

Fix this test

06b2f66

chrisronline removed the blocked label Feb 4, 2019

Remove debug

2b458a3

chrisronline merged commit 4dab26a into elastic:master Feb 4, 2019

chrisronline deleted the monitoring/ccr_enabled_flag branch February 4, 2019 21:15

chrisronline added a commit to chrisronline/kibana that referenced this pull request Feb 4, 2019

Backport elastic#28840

04c22de

chrisronline mentioned this pull request Feb 4, 2019

[6.x] [Monitoring] Add flag to enable/disable CCR monitoring UI (#28840) #30002

Merged

chrisronline added a commit that referenced this pull request Feb 5, 2019

Backport #28840 (#30002)

fbe7667

Conversation

chrisronline commented Jan 16, 2019

Uh oh!

elasticmachine commented Jan 16, 2019

Uh oh!

ycombinator commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jan 16, 2019

💚 Build Succeeded

Uh oh!

chrisronline commented Jan 16, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ycombinator commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisronline commented Jan 16, 2019

Uh oh!

elasticmachine commented Jan 16, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 16, 2019

💔 Build Failed

Uh oh!

chrisronline commented Jan 16, 2019

Uh oh!

ycombinator commented Jan 16, 2019

Uh oh!

elasticmachine commented Jan 16, 2019

💔 Build Failed

Uh oh!

chrisronline Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

ycombinator Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ycombinator Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jan 16, 2019

💚 Build Succeeded

Uh oh!

cachedout Jan 17, 2019

Choose a reason for hiding this comment

Uh oh!

chrisronline Jan 18, 2019

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jan 18, 2019

💚 Build Succeeded

Uh oh!

ycombinator commented Jan 26, 2019

Uh oh!

elasticmachine commented Jan 28, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 28, 2019

💚 Build Succeeded

Uh oh!

cachedout commented Jan 30, 2019

Uh oh!

chrisronline commented Jan 30, 2019

Uh oh!

elasticmachine commented Jan 30, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Feb 4, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Feb 4, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Feb 4, 2019

💚 Build Succeeded

ycombinator commented Jan 16, 2019 •

edited

Loading

ycombinator commented Jan 16, 2019 •

edited

Loading

ycombinator Jan 16, 2019 •

edited

Loading

ycombinator Jan 16, 2019 •

edited

Loading