[Uptime] Implement EuiSuperDatePicker by justinkambic · Pull Request #28217 · elastic/kibana

justinkambic · 2019-01-07T23:23:58Z

Summary

Implementation of EuiSuperDatePicker and comprehensive refactoring of how the plugin handles date ranges.

Testing this PR

Edit the date range on both the Overview and Monitor pages, ensure the views are updated

Note to reviewers

We just added localization to master in [Uptime] Localization #28183, so please mark any bare copy as needing translation!

elasticmachine · 2019-01-07T23:23:59Z

Pinging @elastic/uptime

elasticmachine · 2019-01-07T23:56:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-08T19:22:40Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-09T01:21:10Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-10T19:57:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-10T21:45:44Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

justinkambic · 2019-01-11T17:59:40Z

jenkins test this

elasticmachine · 2019-01-11T18:18:52Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-11T22:56:44Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-15T17:12:28Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-16T15:57:02Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-16T20:50:59Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-16T23:02:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

andrewvc · 2019-01-17T17:37:13Z

SDP should have a seconds interval as well. This is the default, set to 5000.

The refresh button doesn't work either, but that's a separate issue from SDP right @justinkambic ?

andrewvc · 2019-01-17T17:46:05Z

x-pack/plugins/uptime/public/components/queries/monitor_charts/monitor_charts.tsx

          minDuration,
          status,
        }: any) => {
+          maxRtt.push({


What does this do exactly? This could possibly use a comment.

Addressed in 60c613c.

andrewvc

I left some comments about adding additional comments. I'm going to LGTM this conditional to those comments being added.

Great work, I see the code looks much nicer in a number of ways with this PR.

andrewvc · 2019-01-17T17:46:44Z

x-pack/plugins/uptime/public/components/queries/monitor_charts/monitor_charts.tsx

        }
      );

+      const checksDomain = upSeries.concat(downSeries).map(({ y }) => y);


This could probably also use a plain english explanatory comment block

Addressed in 9392894.

andrewvc · 2019-01-17T17:48:45Z

x-pack/plugins/uptime/public/components/queries/snapshot/get_snapshot.ts

+    $dateRangeStart: String!
+    $dateRangeEnd: String!
+    $downCount: Int!
+    $windowSize: Int!


I like the stricter reqs.

andrewvc · 2019-01-17T17:52:41Z

Feel free to merge now. You can address the minutes/seconds issue in a follow-up PR if need be.

justinkambic · 2019-01-17T18:24:32Z

SDP should have a seconds interval as well. This is the default, set to 5000.

Addressed in 28a1d4a.

elasticmachine · 2019-01-17T19:14:19Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

chrisronline

Tested the functionality and seems to work fine!

elasticmachine · 2019-01-18T18:03:45Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Implement EuiSuperDatePicker, update components to use new state props. * Update backend to accept values from EuiSuperDatePicker. * Fix issues with implementation of super date picker. * Fix bug in autorefresh enablement. * Delete obsolete code. * Fix broken types. * Add comment to remind to delete code once it's obsolete. * Fix types. * Remove unused import. * Add polling for ErrorList component. * Update broken unit tests. * Change default autorefresh interval. * Add comments based on PR feedback. * Add comment based on PR feedback.

justinkambic · 2019-01-23T00:07:41Z

Backported to:
6.x/6.7.0 9990165
#29136

justinkambic added WIP Work in progress v7.0.0 refactoring Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v6.7.0 labels Jan 7, 2019

justinkambic removed the WIP Work in progress label Jan 8, 2019

justinkambic mentioned this pull request Jan 9, 2019

[Uptime] 6.7/7.0 Meta Issue #28090

Closed

31 tasks

justinkambic force-pushed the uptime_super-date-picker branch from ddc24f1 to 6b0bc8a Compare January 10, 2019 19:22

justinkambic force-pushed the uptime_super-date-picker branch from 6b0bc8a to 613a76c Compare January 10, 2019 21:06

justinkambic force-pushed the uptime_super-date-picker branch from 699fc59 to 4af93e3 Compare January 11, 2019 17:19

justinkambic requested a review from andrewvc January 11, 2019 17:59

justinkambic added the WIP Work in progress label Jan 11, 2019

justinkambic mentioned this pull request Jan 15, 2019

[Uptime] Localization #28183

Merged

justinkambic force-pushed the uptime_super-date-picker branch from 76687f5 to 3e43147 Compare January 15, 2019 16:49

justinkambic added review and removed WIP Work in progress labels Jan 16, 2019

justinkambic force-pushed the uptime_super-date-picker branch from 3e43147 to 409811c Compare January 16, 2019 15:19

Implement EuiSuperDatePicker, update components to use new state props.

5a8941e

justinkambic added 4 commits January 16, 2019 17:21

Fix types.

f881e0f

Remove unused import.

d3061ac

Add polling for ErrorList component.

1ab50c6

Update broken unit tests.

adee7a3

justinkambic force-pushed the uptime_super-date-picker branch from ee211fc to adee7a3 Compare January 16, 2019 22:21

justinkambic requested a review from chrisronline January 17, 2019 15:44

andrewvc reviewed Jan 17, 2019

View reviewed changes

andrewvc approved these changes Jan 17, 2019

View reviewed changes

Change default autorefresh interval.

28a1d4a

justinkambic added 2 commits January 17, 2019 13:29

Add comments based on PR feedback.

60c613c

Add comment based on PR feedback.

9392894

alvarolobato assigned justinkambic Jan 18, 2019

chrisronline approved these changes Jan 18, 2019

View reviewed changes

Merge branch 'master' into uptime_super-date-picker

74b3ff7

justinkambic merged commit 0cb9932 into elastic:master Jan 18, 2019

justinkambic added the backport pending label Jan 18, 2019

andrewvc mentioned this pull request Jan 18, 2019

[Uptime] Support EUI Super Date Picker #28025

Closed

justinkambic mentioned this pull request Jan 22, 2019

[Uptime] Implement EuiSuperDatePicker (#28217) #29136

Merged

justinkambic removed the backport pending label Jan 23, 2019

justinkambic deleted the uptime_super-date-picker branch January 23, 2019 00:08

Conversation

justinkambic commented Jan 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing this PR

Note to reviewers

Uh oh!

elasticmachine commented Jan 7, 2019

Uh oh!

elasticmachine commented Jan 7, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 8, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 9, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 10, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 10, 2019

💔 Build Failed

Uh oh!

justinkambic commented Jan 11, 2019

Uh oh!

elasticmachine commented Jan 11, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 11, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 15, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 16, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 16, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jan 16, 2019

💚 Build Succeeded

Uh oh!

andrewvc commented Jan 17, 2019

Uh oh!

andrewvc Jan 17, 2019

Choose a reason for hiding this comment

Uh oh!

justinkambic Jan 17, 2019

Choose a reason for hiding this comment

Uh oh!

andrewvc left a comment

Choose a reason for hiding this comment

Uh oh!

andrewvc Jan 17, 2019

Choose a reason for hiding this comment

Uh oh!

justinkambic Jan 17, 2019

Choose a reason for hiding this comment

Uh oh!

andrewvc Jan 17, 2019

Choose a reason for hiding this comment

Uh oh!

justinkambic Jan 17, 2019

Choose a reason for hiding this comment

Uh oh!

andrewvc commented Jan 17, 2019

Uh oh!

justinkambic commented Jan 17, 2019

Uh oh!

elasticmachine commented Jan 17, 2019

💚 Build Succeeded

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jan 18, 2019

💚 Build Succeeded

Uh oh!

justinkambic commented Jan 7, 2019 •

edited

Loading