Skip to content

FIlter phantom circles#2773

Merged
rashidkpc merged 4 commits intoelastic:masterfrom
jthomassie:fix/2763
Jan 27, 2015
Merged

FIlter phantom circles#2773
rashidkpc merged 4 commits intoelastic:masterfrom
jthomassie:fix/2763

Conversation

@jthomassie
Copy link
Copy Markdown

Revised area chart to delete phantom circles, where d.y === 0
Fixes #2763

@stormpython
Copy link
Copy Markdown
Contributor

Instead of adding a function that removes circles, why not filter the data so that circles where d.y === 0 do not get drawn?

…rather than adding a method to remove circles after drawn
@jthomassie
Copy link
Copy Markdown
Author

Good idea @stormpython!

@jthomassie jthomassie changed the title Delete phantom circles FIlter phantom circles Jan 27, 2015
@jthomassie
Copy link
Copy Markdown
Author

Closes #2763

@stormpython
Copy link
Copy Markdown
Contributor

Need to add tests to area chart for this. Should center around testing that no circles are drawn when d.y === 0.

@jthomassie
Copy link
Copy Markdown
Author

Test added, ready for review.

@stormpython
Copy link
Copy Markdown
Contributor

LGTM. Assigning to @rashidkpc for another set of eyes.

@stormpython stormpython assigned rashidkpc and unassigned stormpython Jan 27, 2015
@rashidkpc
Copy link
Copy Markdown
Contributor

LGTM

rashidkpc added a commit that referenced this pull request Jan 27, 2015
@rashidkpc rashidkpc merged commit c66029a into elastic:master Jan 27, 2015
maryam-saeidi added a commit that referenced this pull request Feb 27, 2026
## Summary

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@elastic/charts](https://togithub.com/elastic/elastic-charts) |
dependencies | minor | [`71.1.2` ->
`71.2.0`](elastic/elastic-charts@v71.1.2...v71.2.0)
|


---

### Release Notes
##
[71.2.0](elastic/elastic-charts@v71.1.2...v71.2.0)
(2026-02-26)


### Bug Fixes

* **metric:** update badge to pill shape with adjusted padding
([#2786](elastic/elastic-charts#2786))
([80be269](elastic/elastic-charts@80be269))
* **theme:** expose font weight in text style
([#2788](elastic/elastic-charts#2788))
([02f4afa](elastic/elastic-charts@02f4afa))


### Features

* **legend:** add "list" layout for horizontal legends
([#2784](elastic/elastic-charts#2784))
([8967ce3](elastic/elastic-charts@8967ce3))
* **legend:** add legendActionOnHover option to show actions on hover
([#2773](elastic/elastic-charts#2773))
([d1be88f](elastic/elastic-charts@d1be88f))
qn895 pushed a commit to qn895/kibana that referenced this pull request Mar 11, 2026
## Summary

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@elastic/charts](https://togithub.com/elastic/elastic-charts) |
dependencies | minor | [`71.1.2` ->
`71.2.0`](elastic/elastic-charts@v71.1.2...v71.2.0)
|


---

### Release Notes
##
[71.2.0](elastic/elastic-charts@v71.1.2...v71.2.0)
(2026-02-26)


### Bug Fixes

* **metric:** update badge to pill shape with adjusted padding
([elastic#2786](elastic/elastic-charts#2786))
([80be269](elastic/elastic-charts@80be269))
* **theme:** expose font weight in text style
([elastic#2788](elastic/elastic-charts#2788))
([02f4afa](elastic/elastic-charts@02f4afa))


### Features

* **legend:** add "list" layout for horizontal legends
([elastic#2784](elastic/elastic-charts#2784))
([8967ce3](elastic/elastic-charts@8967ce3))
* **legend:** add legendActionOnHover option to show actions on hover
([elastic#2773](elastic/elastic-charts#2773))
([d1be88f](elastic/elastic-charts@d1be88f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Area charts have hover points at non-existent points

3 participants