[Entity Store] Extract first_seen and last_seen from @timestamp#258495
Merged
[Entity Store] Extract first_seen and last_seen from @timestamp#258495
Conversation
uri-weisman
requested changes
Mar 19, 2026
x-pack/solutions/security/plugins/entity_store/common/domain/definitions/common_fields.ts
Show resolved
Hide resolved
uri-weisman
approved these changes
Mar 19, 2026
Contributor
💚 Build Succeeded
Metrics [docs]
History
cc @kubasobon |
8 tasks
kubasobon
added a commit
that referenced
this pull request
Mar 24, 2026
Fixes a string templating bug introduced by #258495 - Use the validateQuery from @kbn/esql-language to va;idate the ESQL queries we generate. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kubasobon
added a commit
that referenced
this pull request
Mar 24, 2026
Fixes a string templating bug introduced by #258495 - Use the validateQuery from @kbn/esql-language to va;idate the ESQL queries we generate. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
maxcold
added a commit
that referenced
this pull request
Mar 24, 2026
) ## Summary Switches the automated email resolution incremental scan watermark from `@timestamp` to `entity.lifecycle.last_seen`. **Problem:** The history snapshot operation resets `@timestamp` on all entity documents to the current time. This causes automated resolution to do a full re-scan of all entities after every snapshot, instead of only processing entities with genuinely new data. **Fix:** Use `entity.lifecycle.last_seen` instead, which reflects the newest `@timestamp` from source logs and is not affected by the history snapshot operation. Depends on #258495 (merged). ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks - Low risk: This change only affects the field used for incremental scan filtering in automated resolution. If `entity.lifecycle.last_seen` is not populated on an entity (e.g., before the first log extraction after init), the first run is a full scan anyway (`lastProcessedTimestamp` is null → no range filter). --------- Co-authored-by: kubasobon <kuba.sobon@elastic.co> Co-authored-by: Kuba Soboń <wtty.fool@gmail.com>
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Mar 26, 2026
…tic#258495) ## Summary Modifies `entity.lifecycle.first_seen` and `entity.lifecycle.last_seen` to represent true state by holding onto first and latest timestamps respectively. **EDIT:** `entity.lifecycle.last_activity` should stay the same, `last_seen` added. Closes elastic#255084 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Mar 26, 2026
…59057) Fixes a string templating bug introduced by elastic#258495 - Use the validateQuery from @kbn/esql-language to va;idate the ESQL queries we generate. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Mar 26, 2026
…tic#258574) ## Summary Switches the automated email resolution incremental scan watermark from `@timestamp` to `entity.lifecycle.last_seen`. **Problem:** The history snapshot operation resets `@timestamp` on all entity documents to the current time. This causes automated resolution to do a full re-scan of all entities after every snapshot, instead of only processing entities with genuinely new data. **Fix:** Use `entity.lifecycle.last_seen` instead, which reflects the newest `@timestamp` from source logs and is not affected by the history snapshot operation. Depends on elastic#258495 (merged). ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks - Low risk: This change only affects the field used for incremental scan filtering in automated resolution. If `entity.lifecycle.last_seen` is not populated on an entity (e.g., before the first log extraction after init), the first run is a full scan anyway (`lastProcessedTimestamp` is null → no range filter). --------- Co-authored-by: kubasobon <kuba.sobon@elastic.co> Co-authored-by: Kuba Soboń <wtty.fool@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modifies
entity.lifecycle.first_seenandentity.lifecycle.last_seento represent true state by holding onto first and latest timestamps respectively.EDIT:
entity.lifecycle.last_activityshould stay the same,last_seenadded.Closes #255084
Checklist