[One workflow] event-driven scheduling and trigger pagination#257283
Merged
yngrdyn merged 10 commits intoelastic:mainfrom Mar 16, 2026
Merged
[One workflow] event-driven scheduling and trigger pagination#257283yngrdyn merged 10 commits intoelastic:mainfrom
yngrdyn merged 10 commits intoelastic:mainfrom
Conversation
…to avoid overloading ES/Task Manager when many workflows match
dej611
reviewed
Mar 12, 2026
.../plugins/shared/workflows_management/server/workflows_management/workflows_management_api.ts
Show resolved
Hide resolved
| let searchAfter: estypes.SearchHit['sort'] | undefined; | ||
| let hasMore = true; | ||
|
|
||
| while (hasMore) { |
Contributor
There was a problem hiding this comment.
would it make sense to limit this to something?
Something like:
while (hasMore && pageCount < MAX_PAGES) {to avoid unbounded sequential ES requests.
Alternatively the pageCount can be introduced to a more precise hasMore check (see below).
Contributor
Author
There was a problem hiding this comment.
Addressed in 8b987ae, although I'm not sure about the number I used. This number will be confirmed on our next sync (it's arbitrary) but I want this PR to not be blocked by this
...gins/shared/workflows_management/server/workflows_management/workflows_management_service.ts
Outdated
Show resolved
Hide resolved
...gins/shared/workflows_management/server/workflows_management/workflows_management_service.ts
Outdated
Show resolved
Hide resolved
...gins/shared/workflows_management/server/workflows_management/workflows_management_service.ts
Show resolved
Hide resolved
dej611
reviewed
Mar 16, 2026
src/platform/plugins/shared/workflows_management/server/event_driven/trigger_event_handler.ts
Outdated
Show resolved
Hide resolved
...gins/shared/workflows_management/server/workflows_management/workflows_management_service.ts
Show resolved
Hide resolved
Comment on lines
+739
to
+741
| const pageSize = 1000; | ||
| const MAX_PAGES = 100; | ||
| const keepAlive = '1m'; |
Contributor
There was a problem hiding this comment.
1000 * 100 workflows in 1 minute sounds quite a challenging number.
Perhaps the amount of workflow can be lowered down a bit here?
Contributor
Author
There was a problem hiding this comment.
For the moment this is an arbitrary number, I'd like to take this discussion to our next sync
| expect(maxConcurrent).toBeLessThanOrEqual(20); | ||
| }); | ||
|
|
||
| it('should resolve after all scheduleWorkflow calls are invoked (fire-and-forget scheduling)', async () => { |
Contributor
There was a problem hiding this comment.
it is relaly fire-and-forget? The code is waiting with allSettled inside
Contributor
Author
There was a problem hiding this comment.
It's waiting for the scheduling not the run of those workflows
dej611
approved these changes
Mar 16, 2026
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
cc @yngrdyn |
sorenlouv
pushed a commit
that referenced
this pull request
Mar 17, 2026
Addresses open review comments on [event-driven workflow execution](#254964): concurrency/back pressure, pagination and related tests. ## Summary When many workflows are subscribed to a trigger, emitting an event can overload the node if we run them all inline. This PR **schedules** event-driven workflow runs via **TM** (same model as alerts) and caps concurrent **scheduling** with **p-limit** so `es` and `TM` are not flooded. It also fixes **silent truncation** when more than 1000 workflows match a trigger by implementing **PIT + search_after** in `getWorkflowsSubscribedToTrigger`, so all matching workflows are returned.
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Mar 26, 2026
…c#257283) Addresses open review comments on [event-driven workflow execution](elastic#254964): concurrency/back pressure, pagination and related tests. ## Summary When many workflows are subscribed to a trigger, emitting an event can overload the node if we run them all inline. This PR **schedules** event-driven workflow runs via **TM** (same model as alerts) and caps concurrent **scheduling** with **p-limit** so `es` and `TM` are not flooded. It also fixes **silent truncation** when more than 1000 workflows match a trigger by implementing **PIT + search_after** in `getWorkflowsSubscribedToTrigger`, so all matching workflows are returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses open review comments on event-driven workflow execution: concurrency/back pressure, pagination and related tests.
Summary
When many workflows are subscribed to a trigger, emitting an event can overload the node if we run them all inline. This PR schedules event-driven workflow runs via TM (same model as alerts) and caps concurrent scheduling with p-limit so
esandTMare not flooded. It also fixes silent truncation when more than 1000 workflows match a trigger by implementing PIT + search_after ingetWorkflowsSubscribedToTrigger, so all matching workflows are returned.