[Security Solution] fix potential issues with loading data views in detection engine#256996
Merged
PhilippeOberti merged 1 commit intoelastic:mainfrom Mar 17, 2026
Merged
Conversation
e6105ea to
fc99ac8
Compare
fc99ac8 to
63b3cb9
Compare
rylnd
approved these changes
Mar 17, 2026
Contributor
rylnd
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the added safety, here.
Contributor
|
Starting backport for target branches: 9.2, 9.3 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 17, 2026
…etection engine (elastic#256996) ## Summary A recent SDH made us realize that we have a potential issue in our code, when the platform dataview service throws errors. This previous [PR](elastic#256983) fixes the issue in the @elastic/security-threat-hunting-investigations codebase and we want to merge it for `9.2.7`. This PR applies similar changes to the code owned by the @elastic/security-detection-engine team: - wrap the `dataview.get` calls within a `try/catch` and show a toast if an error happens This will facilitate debugging if we ever need. (more info in the PR mentioned above). ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 243e138)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 17, 2026
…etection engine (elastic#256996) ## Summary A recent SDH made us realize that we have a potential issue in our code, when the platform dataview service throws errors. This previous [PR](elastic#256983) fixes the issue in the @elastic/security-threat-hunting-investigations codebase and we want to merge it for `9.2.7`. This PR applies similar changes to the code owned by the @elastic/security-detection-engine team: - wrap the `dataview.get` calls within a `try/catch` and show a toast if an error happens This will facilitate debugging if we ever need. (more info in the PR mentioned above). ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 243e138)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 17, 2026
…s in detection engine (#256996) (#258236) # Backport This will backport the following commits from `main` to `9.3`: - [[Security Solution] fix potential issues with loading data views in detection engine (#256996)](#256996) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2026-03-17T20:37:25Z","message":"[Security Solution] fix potential issues with loading data views in detection engine (#256996)\n\n## Summary\n\nA recent SDH made us realize that we have a potential issue in our code,\nwhen the platform dataview service throws errors.\nThis previous [PR](#256983) fixes\nthe issue in the @elastic/security-threat-hunting-investigations\ncodebase and we want to merge it for `9.2.7`.\n\nThis PR applies similar changes to the code owned by the\n@elastic/security-detection-engine team:\n- wrap the `dataview.get` calls within a `try/catch` and show a toast if\nan error happens\n\nThis will facilitate debugging if we ever need. (more info in the PR\nmentioned above).\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"243e138188a1f2853af4999fd148215a3f3fe9f4","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","backport:version","v9.4.0","v9.2.7","v9.3.2"],"title":"[Security Solution] fix potential issues with loading data views in detection engine","number":256996,"url":"https://github.com/elastic/kibana/pull/256996","mergeCommit":{"message":"[Security Solution] fix potential issues with loading data views in detection engine (#256996)\n\n## Summary\n\nA recent SDH made us realize that we have a potential issue in our code,\nwhen the platform dataview service throws errors.\nThis previous [PR](#256983) fixes\nthe issue in the @elastic/security-threat-hunting-investigations\ncodebase and we want to merge it for `9.2.7`.\n\nThis PR applies similar changes to the code owned by the\n@elastic/security-detection-engine team:\n- wrap the `dataview.get` calls within a `try/catch` and show a toast if\nan error happens\n\nThis will facilitate debugging if we ever need. (more info in the PR\nmentioned above).\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"243e138188a1f2853af4999fd148215a3f3fe9f4"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.3"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/256996","number":256996,"mergeCommit":{"message":"[Security Solution] fix potential issues with loading data views in detection engine (#256996)\n\n## Summary\n\nA recent SDH made us realize that we have a potential issue in our code,\nwhen the platform dataview service throws errors.\nThis previous [PR](#256983) fixes\nthe issue in the @elastic/security-threat-hunting-investigations\ncodebase and we want to merge it for `9.2.7`.\n\nThis PR applies similar changes to the code owned by the\n@elastic/security-detection-engine team:\n- wrap the `dataview.get` calls within a `try/catch` and show a toast if\nan error happens\n\nThis will facilitate debugging if we ever need. (more info in the PR\nmentioned above).\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"243e138188a1f2853af4999fd148215a3f3fe9f4"}},{"branch":"9.2","label":"v9.2.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.3","label":"v9.3.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 17, 2026
…s in detection engine (#256996) (#258235) # Backport This will backport the following commits from `main` to `9.2`: - [[Security Solution] fix potential issues with loading data views in detection engine (#256996)](#256996) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2026-03-17T20:37:25Z","message":"[Security Solution] fix potential issues with loading data views in detection engine (#256996)\n\n## Summary\n\nA recent SDH made us realize that we have a potential issue in our code,\nwhen the platform dataview service throws errors.\nThis previous [PR](#256983) fixes\nthe issue in the @elastic/security-threat-hunting-investigations\ncodebase and we want to merge it for `9.2.7`.\n\nThis PR applies similar changes to the code owned by the\n@elastic/security-detection-engine team:\n- wrap the `dataview.get` calls within a `try/catch` and show a toast if\nan error happens\n\nThis will facilitate debugging if we ever need. (more info in the PR\nmentioned above).\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"243e138188a1f2853af4999fd148215a3f3fe9f4","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","backport:version","v9.4.0","v9.2.7","v9.3.2"],"title":"[Security Solution] fix potential issues with loading data views in detection engine","number":256996,"url":"https://github.com/elastic/kibana/pull/256996","mergeCommit":{"message":"[Security Solution] fix potential issues with loading data views in detection engine (#256996)\n\n## Summary\n\nA recent SDH made us realize that we have a potential issue in our code,\nwhen the platform dataview service throws errors.\nThis previous [PR](#256983) fixes\nthe issue in the @elastic/security-threat-hunting-investigations\ncodebase and we want to merge it for `9.2.7`.\n\nThis PR applies similar changes to the code owned by the\n@elastic/security-detection-engine team:\n- wrap the `dataview.get` calls within a `try/catch` and show a toast if\nan error happens\n\nThis will facilitate debugging if we ever need. (more info in the PR\nmentioned above).\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"243e138188a1f2853af4999fd148215a3f3fe9f4"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.3"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/256996","number":256996,"mergeCommit":{"message":"[Security Solution] fix potential issues with loading data views in detection engine (#256996)\n\n## Summary\n\nA recent SDH made us realize that we have a potential issue in our code,\nwhen the platform dataview service throws errors.\nThis previous [PR](#256983) fixes\nthe issue in the @elastic/security-threat-hunting-investigations\ncodebase and we want to merge it for `9.2.7`.\n\nThis PR applies similar changes to the code owned by the\n@elastic/security-detection-engine team:\n- wrap the `dataview.get` calls within a `try/catch` and show a toast if\nan error happens\n\nThis will facilitate debugging if we ever need. (more info in the PR\nmentioned above).\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"243e138188a1f2853af4999fd148215a3f3fe9f4"}},{"branch":"9.2","label":"v9.2.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.3","label":"v9.3.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Mar 18, 2026
…etection engine (elastic#256996) ## Summary A recent SDH made us realize that we have a potential issue in our code, when the platform dataview service throws errors. This previous [PR](elastic#256983) fixes the issue in the @elastic/security-threat-hunting-investigations codebase and we want to merge it for `9.2.7`. This PR applies similar changes to the code owned by the @elastic/security-detection-engine team: - wrap the `dataview.get` calls within a `try/catch` and show a toast if an error happens This will facilitate debugging if we ever need. (more info in the PR mentioned above). ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Mar 26, 2026
…etection engine (elastic#256996) ## Summary A recent SDH made us realize that we have a potential issue in our code, when the platform dataview service throws errors. This previous [PR](elastic#256983) fixes the issue in the @elastic/security-threat-hunting-investigations codebase and we want to merge it for `9.2.7`. This PR applies similar changes to the code owned by the @elastic/security-detection-engine team: - wrap the `dataview.get` calls within a `try/catch` and show a toast if an error happens This will facilitate debugging if we ever need. (more info in the PR mentioned above). ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A recent SDH made us realize that we have a potential issue in our code, when the platform dataview service throws errors.
This previous PR fixes the issue in the @elastic/security-threat-hunting-investigations codebase and we want to merge it for
9.2.7.This PR applies similar changes to the code owned by the @elastic/security-detection-engine team:
dataview.getcalls within atry/catchand show a toast if an error happensThis will facilitate debugging if we ever need. (more info in the PR mentioned above).
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelinesbackport:*labels.