[SavedObjects] Allow schema-only changes in the latest model version without a version bump by gsoldevila · Pull Request #256432 · elastic/kibana

gsoldevila · 2026-03-06T11:47:11Z

Summary

When a saved object type's schema validation constraints are tightened (e.g. adding a maxSize limit to an array field) without touching the underlying ES mappings, the 'Check changes in Saved Objects' CI check was incorrectly rejecting the change as a forbidden model version mutation.

This PR relaxes the validation to allow schema-only changes to the latest model version, provided all three conditions hold:

Only the latest model version's schemas were modified (no older versions touched).
The mappings have not been modified.
The latest model version's schema still covers all mapped fields (validateAllMappingsInModelVersion still passes).

When this exceptional case is detected, a warning is emitted in the CI output making it clear why the change is allowed and reminding that any future mapping changes will still require a proper model version bump.

Context

Fixes the CI failure on #255741, where adding a maxSize constraint to the tags field in the security-rule SO type caused the check to fail.

Tracking task: https://github.com/elastic/kibana-team/issues/3021 (sub-issue of https://github.com/elastic/kibana-team/issues/2349)

Made with Cursor

coderabbitai · 2026-03-06T11:50:50Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (4)

reviewer:coderabbit
Team:Search
Team:Operations
Team:QA

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 3c44e870-0ba6-4201-8fa0-9a512617daab

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

elasticmachine · 2026-03-09T11:17:33Z

Pinging @elastic/kibana-core (Team:Core)

gsoldevila · 2026-03-09T14:30:38Z

/ci-ralph

gsoldevila · 2026-03-09T15:26:46Z

/ralph check the test failures of build 406651 and fix them

Build URL: https://buildkite.com/elastic/kibana-pull-request/builds/406651

Use ci/bk-build-info.sh 406651 to fetch detailed build failure information.

elasticmachine · 2026-03-09T16:56:21Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: d1471e0

Failed CI Steps

Scout: [ platform / spaces ] plugin

Test Failures

[job] [logs] Scout: [ platform / spaces ] plugin / local-serverless-security_complete - Spaces selection - as Admin - displays the space selection menu in header

Metrics [docs]

✅ unchanged

History

💔 Build #406651 failed 5870d68

hammad-nasir-elastic · 2026-03-10T17:23:01Z

packages/kbn-check-saved-objects-cli/src/commands/tasks/validate_updated_types.ts

-              to: ctx.to?.typeDefinitions[name]!,
+              from: ctx.from!.typeDefinitions[type.name],
+              to: ctx.to?.typeDefinitions[type.name]!,
+              registeredType: type,


Should registeredType and log also be included in validate_updated_types.ts as part of the recently merged serverless baseline check to prevent schema only changes failing against the serverless baseline?

Makes total sense, good catch! I totally forgot about your in-flight PR.

hammad-nasir-elastic · 2026-03-10T18:00:24Z

packages/kbn-check-saved-objects-cli/src/snapshots/validate_changes.test.ts

+      const to = loadSnapshot('schema_only_change_in_latest_model_version_updated.json');
+      const log = jest.fn();
+
+      expect(() => validateChangesWrapper({ from, to, name: 'task', log })).not.toThrow();


I noticed that registeredType isn’t being passed, and I’m wondering whether we should pass a mock registeredType to exercise the validateAllMappingsInModelVersion path that I believe would cover the scenario where there’s a schema only change but the schema doesn’t cover all mapped fields resulting in a throw.

hammad-nasir-elastic

LGTM overall! Just had 2 questions but will unblock for any progress/updates.

…without a version bump When a saved object type's schema validation constraints are tightened (e.g. adding a maxSize limit) without touching the ES mappings, the CI check was incorrectly rejecting the change as a model version mutation. Schema-only changes to the LATEST model version are now allowed when: - No older model versions were mutated. - The mappings have not been modified. - The latest model version's schema still covers all mapped fields. A warning is emitted in this case to make the exceptional nature of the allowance explicit. Closes: elastic/kibana-team#3021 Made-with: Cursor

…without a version bump (#256432) ## Summary When a saved object type's schema validation constraints are tightened (e.g. adding a `maxSize` limit to an array field) without touching the underlying ES mappings, the 'Check changes in Saved Objects' CI check was incorrectly rejecting the change as a forbidden model version mutation. This PR relaxes the validation to allow schema-only changes to the **latest** model version, provided all three conditions hold: - Only the latest model version's schemas were modified (no older versions touched). - The mappings have not been modified. - The latest model version's schema still covers all mapped fields (`validateAllMappingsInModelVersion` still passes). When this exceptional case is detected, a warning is emitted in the CI output making it clear why the change is allowed and reminding that any future mapping changes will still require a proper model version bump. ## Context Fixes the CI failure on #255741, where adding a `maxSize` constraint to the `tags` field in the `security-rule` SO type caused the check to fail. Tracking task: https://github.com/elastic/kibana-team/issues/3021 (sub-issue of https://github.com/elastic/kibana-team/issues/2349) Made with [Cursor](https://cursor.com)

…without a version bump (elastic#256432) ## Summary When a saved object type's schema validation constraints are tightened (e.g. adding a `maxSize` limit to an array field) without touching the underlying ES mappings, the 'Check changes in Saved Objects' CI check was incorrectly rejecting the change as a forbidden model version mutation. This PR relaxes the validation to allow schema-only changes to the **latest** model version, provided all three conditions hold: - Only the latest model version's schemas were modified (no older versions touched). - The mappings have not been modified. - The latest model version's schema still covers all mapped fields (`validateAllMappingsInModelVersion` still passes). When this exceptional case is detected, a warning is emitted in the CI output making it clear why the change is allowed and reminding that any future mapping changes will still require a proper model version bump. ## Context Fixes the CI failure on elastic#255741, where adding a `maxSize` constraint to the `tags` field in the `security-rule` SO type caused the check to fail. Tracking task: elastic/kibana-team#3021 (sub-issue of elastic/kibana-team#2349) Made with [Cursor](https://cursor.com)

gsoldevila added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Mar 6, 2026

gsoldevila marked this pull request as ready for review March 9, 2026 11:17

gsoldevila requested a review from a team as a code owner March 9, 2026 11:17

hammad-nasir-elastic reviewed Mar 10, 2026

View reviewed changes

hammad-nasir-elastic approved these changes Mar 10, 2026

View reviewed changes

gsoldevila added 2 commits March 11, 2026 10:06

Address PR feedback

0f3f585

gsoldevila force-pushed the cps-so-schema-only-change branch from d1471e0 to 0f3f585 Compare March 11, 2026 12:27

gsoldevila enabled auto-merge (squash) March 11, 2026 12:29

gsoldevila merged commit 80b433d into elastic:main Mar 11, 2026
18 checks passed

kibanamachine added the v9.4.0 label Mar 11, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SavedObjects] Allow schema-only changes in the latest model version without a version bump#256432

[SavedObjects] Allow schema-only changes in the latest model version without a version bump#256432
gsoldevila merged 2 commits intoelastic:mainfrom
gsoldevila:cps-so-schema-only-change

gsoldevila commented Mar 6, 2026

Uh oh!

coderabbitai bot commented Mar 6, 2026 •

edited

Loading

Review skipped

Uh oh!

elasticmachine commented Mar 9, 2026

Uh oh!

gsoldevila commented Mar 9, 2026

Uh oh!

gsoldevila commented Mar 9, 2026

Uh oh!

elasticmachine commented Mar 9, 2026

Uh oh!

hammad-nasir-elastic Mar 10, 2026 •

edited

Loading

Uh oh!

gsoldevila Mar 11, 2026

Uh oh!

hammad-nasir-elastic Mar 10, 2026

Uh oh!

hammad-nasir-elastic left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gsoldevila commented Mar 6, 2026

Summary

Context

Uh oh!

coderabbitai bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

elasticmachine commented Mar 9, 2026

Uh oh!

gsoldevila commented Mar 9, 2026

Uh oh!

gsoldevila commented Mar 9, 2026

Uh oh!

elasticmachine commented Mar 9, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

History

Uh oh!

hammad-nasir-elastic Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gsoldevila Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

hammad-nasir-elastic Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

hammad-nasir-elastic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Mar 6, 2026 •

edited

Loading

hammad-nasir-elastic Mar 10, 2026 •

edited

Loading