[ES|QL] Add buckets param to Promql#253630
Merged
bartoval merged 5 commits intoelastic:mainfrom Feb 18, 2026
Merged
Conversation
3a0d230 to
3bdbe78
Compare
Contributor
Author
|
Currently, Then we will be able to call |
Member
|
Wow, that was quick. Thanks a lot for working on it. I watched the video and it looks great! Just some nuance:
The parameter is called
I think this should be: If |
3bdbe78 to
c364bc0
Compare
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
Contributor
⏳ Build in-progress, with failures
Failed CI Stepscc @bartoval |
stratoula
approved these changes
Feb 18, 2026
src/platform/packages/shared/kbn-esql-language/src/commands/registry/promql/autocomplete.ts
Outdated
Show resolved
Hide resolved
…gistry/promql/autocomplete.ts Co-authored-by: Stratou <stratoula1@gmail.com>
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
Feb 19, 2026
## Summary part of elastic#246728 We add a new param called `buckets `elastic/elasticsearch#142582 https://github.com/user-attachments/assets/a3faa37e-5cd6-4b6e-bc1d-d5afa717c2ff This change makes the following behavior explicit: - step is optional. - If step is not set, it is derived from buckets, start, and end. If buckets is not set, it defaults to 100. - If buckets is set (or start and end are set), we still pass step as next column. - Steps and buckets are mutually exclusive for validation and autocomplete (I added the video before implementing the autocomplete part) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Stratou <stratoula1@gmail.com>
ersin-erdal
pushed a commit
to ersin-erdal/kibana
that referenced
this pull request
Feb 19, 2026
## Summary part of elastic#246728 We add a new param called `buckets `elastic/elasticsearch#142582 https://github.com/user-attachments/assets/a3faa37e-5cd6-4b6e-bc1d-d5afa717c2ff This change makes the following behavior explicit: - step is optional. - If step is not set, it is derived from buckets, start, and end. If buckets is not set, it defaults to 100. - If buckets is set (or start and end are set), we still pass step as next column. - Steps and buckets are mutually exclusive for validation and autocomplete (I added the video before implementing the autocomplete part) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Stratou <stratoula1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
part of #246728
We add a new param called
bucketselastic/elasticsearch#142582bucket.mp4
This change makes the following behavior explicit: